You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/06/21 04:50:25 UTC

[kudu-CR] Mark the Response accessors in transactions/transaction's state const 

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3419

Change subject: Mark the Response accessors in transactions/transaction's state const
......................................................................

Mark the Response accessors in transactions/transaction's state const

There is no reason why these accessors should't be const and by making
them as such we can access the response through state(), instead of
mutable_state().

Change-Id: I7dbcc4bf8fc657a80f08806ce5e016601ef429bc
---
M src/kudu/tablet/transactions/alter_schema_transaction.h
M src/kudu/tablet/transactions/transaction.h
M src/kudu/tablet/transactions/write_transaction.h
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3419/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dbcc4bf8fc657a80f08806ce5e016601ef429bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>

[kudu-CR] Mark the Response accessors in transactions/transaction's state const

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Mark the Response accessors in transactions/transaction's state const
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1913/

-- 
To view, visit http://gerrit.cloudera.org:8080/3419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dbcc4bf8fc657a80f08806ce5e016601ef429bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Mark the Response accessors in transactions/transaction's state const

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.

Change subject: Mark the Response accessors in transactions/transaction's state const
......................................................................


Mark the Response accessors in transactions/transaction's state const

There is no reason why these accessors should't be const and by making
them as such we can access the response through state(), instead of
mutable_state().

Change-Id: I7dbcc4bf8fc657a80f08806ce5e016601ef429bc
Reviewed-on: http://gerrit.cloudera.org:8080/3419
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tablet/transactions/alter_schema_transaction.h
M src/kudu/tablet/transactions/transaction.h
M src/kudu/tablet/transactions/write_transaction.h
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7dbcc4bf8fc657a80f08806ce5e016601ef429bc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Mark the Response accessors in transactions/transaction's state const

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Mark the Response accessors in transactions/transaction's state const
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dbcc4bf8fc657a80f08806ce5e016601ef429bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No