[GitHub] [arrow] alamb commented on pull request #8715: ARROW-10656: [Rust] Use DataType comparison without values

[GitBox <gi...@apache.org>]

alamb commented on pull request #8715:
URL: https://github.com/apache/arrow/pull/8715#issuecomment-731581032


   > However, we should be clear to the users what is actually compared and what is not. If we end up in a scenario where some attributes play a role and some do not this is really hard to understand for anyone.
   
   I agree that the current situation is confusing
   
   I  think the core of the issue is that the "can the field be nullable" is logically part of a `DataType`, though the way the code is now that information is only part of the `DataType` for nested fields (for other structures, the nullability information is only encoded in a `Field` wrapper around the datatype. 
   
   I personally think changing `Field` to `(nulable, data_type)` in List would be a reasonable compromise and at least avoid the confusion about field names


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org