You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by "cdmikechen (via GitHub)" <gi...@apache.org> on 2023/02/27 04:48:00 UTC

[GitHub] [submarine] cdmikechen opened a new pull request, #1052: SUBMARINE-1370. Fix Calculate combined coverage failed

cdmikechen opened a new pull request, #1052:
URL: https://github.com/apache/submarine/pull/1052

   ### What is this PR for?
   Fix Calculate combined coverage step failed.
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] - Add mvn build step
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-1370
   
   ### How should this be tested?
   NA
   
   ### Screenshots (if appropriate)
   NA
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [submarine] codecov[bot] commented on pull request #1052: SUBMARINE-1370. Fix Calculate combined coverage failed

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1052:
URL: https://github.com/apache/submarine/pull/1052#issuecomment-1445713840

   # [Codecov](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1052](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4cdfddf) into [master](https://codecov.io/gh/apache/submarine/commit/8360aec09b8640dc55d22a913cf7f8280f93b180?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8360aec) will **decrease** coverage by `16.89%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1052       +/-   ##
   ===========================================
   - Coverage   75.98%   59.09%   -16.89%     
   ===========================================
     Files         119      119               
     Lines        5000     4924       -76     
   ===========================================
   - Hits         3799     2910      -889     
   - Misses       1201     2014      +813     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python-integration | `59.09% <ø> (-0.63%)` | :arrow_down: |
   | python-unit | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dk/pysubmarine/submarine/ml/tensorflow/model/fm.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9tb2RlbC9mbS5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...k/pysubmarine/submarine/ml/tensorflow/model/nfm.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9tb2RlbC9uZm0ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../pysubmarine/submarine/ml/tensorflow/parameters.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9wYXJhbWV0ZXJzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../pysubmarine/submarine/ml/tensorflow/registries.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9yZWdpc3RyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...pysubmarine/submarine/ml/tensorflow\_v2/model/fm.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvd192Mi9tb2RlbC9mbS5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ysubmarine/submarine/ml/tensorflow/model/deepfm.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9tb2RlbC9kZWVwZm0ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ysubmarine/submarine/ml/tensorflow\_v2/model/nfm.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvd192Mi9tb2RlbC9uZm0ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...submarine/submarine/ml/tensorflow\_v2/parameters.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvd192Mi9wYXJhbWV0ZXJzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...submarine/submarine/ml/tensorflow\_v2/registries.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvd192Mi9yZWdpc3RyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ubmarine/submarine/ml/tensorflow/input/\_\_init\_\_.py](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9pbnB1dC9fX2luaXRfXy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [53 more](https://codecov.io/gh/apache/submarine/pull/1052?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [submarine] asfgit closed pull request #1052: SUBMARINE-1370. Fix Calculate combined coverage failed

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #1052: SUBMARINE-1370. Fix Calculate combined coverage failed
URL: https://github.com/apache/submarine/pull/1052


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org