You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/25 15:22:04 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #7184: libs: fix visual studio Compiler Error C2124
anchao opened a new pull request, #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184
## Summary
libs: fix visual studio Compiler Error C2124
D:\code\incubator-nuttx\libs\libc\stdlib\lib_strtod.c: error C2124: divide or mod by zero
Windows MSVC restrictions, MSVC doesn't allow division through a
zero literal, but allows it through non-const variable set to zero
Reference:
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2124?view=msvc-170
Signed-off-by: chao an <an...@xiaomi.com>
## Impact
N/A
## Testing
cmake + sim/windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #7184: libs: fix visual studio Compiler Error C2124
Posted by GitBox <gi...@apache.org>.
btashton commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257257477
> @acassis seems that it is not a matter of retry. I can't access that URL from my laptop as well. Something is wrong with that repo
Yeah looks like they are having a partial outage. https://bitbucket.status.atlassian.com/incidents/3308g2hlkfsx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7184: libs: fix visual studio Compiler Error C2124
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257510475
But anyway we need one shared(not individual) and reliable place to host the change can't upstream or tools which isn't maintained anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7184: libs: fix visual studio Compiler Error C2124
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257275326
Let's ignore the false alarm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7184: libs: fix visual studio Compiler Error C2124
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257255516
@acassis seems that it is not a matter of retry. I can't access that URL from my laptop as well. Something is wrong with that repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #7184: libs: fix visual studio Compiler Error C2124
Posted by GitBox <gi...@apache.org>.
btashton commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257453088
> How about we fork https://bitbucket.org/nuttx/tools.git to https://github.com/NuttX? @btashton @pkarashchenko @acassis
This has come up before that https://github.com/NuttX will need to be removed. We don't have a great home for the content that is in the bitbucket repo since much of it cannot be apache licenced.
Some of it is also broken. I forked nxflat from it and fixed some bugs here. https://github.com/btashton/nxflat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7184: libs: fix visual studio Compiler Error C2124
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7184: libs: fix visual studio Compiler Error C2124
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257444381
How about we fork https://bitbucket.org/nuttx/tools.git to https://github.com/NuttX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7184: libs: fix visual studio Compiler Error C2124
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7184:
URL: https://github.com/apache/incubator-nuttx/pull/7184#issuecomment-1257219647
Is it possible to change the CI script to try again when these kind of errors show up:
```
Cloning into '/Users/runner/work/incubator-nuttx/incubator-nuttx/sources/tools'...
fatal: unable to access 'https://bitbucket.org/nuttx/tools.git/': Empty reply from server
Error: Process completed with exit code 128.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org