You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/12/08 05:47:59 UTC

[PR] [SPARK-46321][PS][TESTS] Re-ennable `IndexesTests.test_asof` that was skipped due to Pandas bug [spark]

itholic opened a new pull request, #44250:
URL: https://github.com/apache/spark/pull/44250

   
   ### What changes were proposed in this pull request?
   
   This PR proposes to re-ennable `IndexesTests.test_asof` that was skipped due to Pandas bug
   
   
   ### Why are the changes needed?
   
   The pandas bug has been fixed, so we can improve the test coverage.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Enabling the UTs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46321][PS][TESTS] Re-ennable `IndexesTests.test_asof` that was skipped due to Pandas bug [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44250: [SPARK-46321][PS][TESTS] Re-ennable `IndexesTests.test_asof` that was skipped due to Pandas bug
URL: https://github.com/apache/spark/pull/44250


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46321][PS][TESTS] Re-ennable `IndexesTests.test_asof` that was skipped due to Pandas bug [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44250:
URL: https://github.com/apache/spark/pull/44250#issuecomment-1846659809

   `pandas` passed. Merged to master.
   ![Screenshot 2023-12-07 at 11 03 58 PM](https://github.com/apache/spark/assets/9700541/31627ce3-9e1a-4e11-a9ca-95d131e7a5ae)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org