You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/09 21:01:19 UTC

[GitHub] [tvm] vinx13 commented on a diff in pull request #11654: [TVMSCRIPT] Improve tvmscript type hints

vinx13 commented on code in PR #11654:
URL: https://github.com/apache/tvm/pull/11654#discussion_r893955775


##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -299,7 +284,7 @@ special_stmt - Annotations
 """
 
 def buffer_var(dtype: str, storage_scope: str) -> Var: ...
-def func_attr(attrs: Mapping[str, Object]) -> None: ...
+def func_attr(attrs: Mapping[str, Object | str | bool | int | float]) -> None: ...

Review Comment:
   `|` syntax is only available in python 3.10, we may prefer using `Union` for now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org