[GitHub] [spark] HyukjinKwon commented on a change in pull request #27888: [SPARK-31116][SQL] Consider case sensitivity in ParquetRowConverter

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #27888: [SPARK-31116][SQL] Consider case sensitivity in ParquetRowConverter
URL: https://github.com/apache/spark/pull/27888#discussion_r391984921
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
 ##########
 @@ -842,6 +842,162 @@ class FileBasedDataSourceSuite extends QueryTest
       }
     }
   }
+
+  test("SPARK-31116: Select simple parquet columns correctly in case insensitive manner") {
 
 Review comment:
   Do you target to test this in ORC too? Nested ORC column pruning was added as of SPARK-27034 in Spark 3.0. If you don't target to test ORC too, we might have to move the test case to Parquet specific suite.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org