You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/09 02:18:10 UTC
[GitHub] [flink] wanglijie95 opened a new pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
wanglijie95 opened a new pull request #18672:
URL: https://github.com/apache/flink/pull/18672
## What is the purpose of the change
Introduce job property `isDynamicGraph` to `ExecutionConfig`. In the first step, the property will be decided automatically, true iff config `jobmanager.scheduler` is `AdaptiveBatch`.
## Verifying this change
UT `ExecutionConfigTest#testLoadingIsDynamicGraphFromConfiguration`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**no**)
- The S3 file system connector: (**no**)
## Documentation
- Does this pull request introduce a new feature? (**no**)
- If yes, how is the feature documented? (**not applicable**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1035697155
The CI is green except for known issues.
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033518994
Thanks for review @zhuzhurk . I 've adderessed all your comments. Please help to review it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081",
"triggerID" : "e88e25f069efe98417e027028d3fdf202379dd92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998)
* e88e25f069efe98417e027028d3fdf202379dd92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1034692239
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e88e25f069efe98417e027028d3fdf202379dd92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998)
* e88e25f069efe98417e027028d3fdf202379dd92 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #18672:
URL: https://github.com/apache/flink/pull/18672#discussion_r802230527
##########
File path: flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigTest.java
##########
@@ -279,6 +281,26 @@ public void testLoadingDefaultKryoSerializersFromConfiguration() {
assertThat(configFromConfiguration, equalTo(configFromSetters));
}
+ @Test
+ public void testLoadingIsDynamicGraphFromConfiguration() {
+ testLoadingIsDynamicGraphFromConfiguration(
+ JobManagerOptions.SchedulerType.AdaptiveBatch, true);
+ testLoadingIsDynamicGraphFromConfiguration(JobManagerOptions.SchedulerType.Ng, false);
+ testLoadingIsDynamicGraphFromConfiguration(JobManagerOptions.SchedulerType.Adaptive, false);
+ }
+
+ public void testLoadingIsDynamicGraphFromConfiguration(
Review comment:
can be private
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java
##########
@@ -153,6 +154,8 @@
private RestartStrategies.RestartStrategyConfiguration restartStrategyConfiguration =
new RestartStrategies.FallbackRestartStrategyConfiguration();
+ private boolean isDynamicGraph = false;
Review comment:
The `equals()`, `hashCode()` and `toString()` methods should also be updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081",
"triggerID" : "e88e25f069efe98417e027028d3fdf202379dd92",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081",
"triggerID" : "1034692239",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* e88e25f069efe98417e027028d3fdf202379dd92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 684a97f9456209609f00381df489b6dc17e329f4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk closed pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
zhuzhurk closed pull request #18672:
URL: https://github.com/apache/flink/pull/18672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 154cd56e0f3298e2190cffe947e2f283f5c7d2ec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 154cd56e0f3298e2190cffe947e2f283f5c7d2ec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961)
* 684a97f9456209609f00381df489b6dc17e329f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 154cd56e0f3298e2190cffe947e2f283f5c7d2ec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961)
* 684a97f9456209609f00381df489b6dc17e329f4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 154cd56e0f3298e2190cffe947e2f283f5c7d2ec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081",
"triggerID" : "e88e25f069efe98417e027028d3fdf202379dd92",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081",
"triggerID" : "1034692239",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* e88e25f069efe98417e027028d3fdf202379dd92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 154cd56e0f3298e2190cffe947e2f283f5c7d2ec Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961)
* 684a97f9456209609f00381df489b6dc17e329f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033273702
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 154cd56e0f3298e2190cffe947e2f283f5c7d2ec (Wed Feb 09 02:23:00 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25996).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081",
"triggerID" : "e88e25f069efe98417e027028d3fdf202379dd92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e88e25f069efe98417e027028d3fdf202379dd92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081",
"triggerID" : "e88e25f069efe98417e027028d3fdf202379dd92",
"triggerType" : "PUSH"
}, {
"hash" : "e88e25f069efe98417e027028d3fdf202379dd92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081",
"triggerID" : "1034692239",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* e88e25f069efe98417e027028d3fdf202379dd92 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31081)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 684a97f9456209609f00381df489b6dc17e329f4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965)
* ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30998)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033272608
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30961",
"triggerID" : "154cd56e0f3298e2190cffe947e2f283f5c7d2ec",
"triggerType" : "PUSH"
}, {
"hash" : "684a97f9456209609f00381df489b6dc17e329f4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965",
"triggerID" : "684a97f9456209609f00381df489b6dc17e329f4",
"triggerType" : "PUSH"
}, {
"hash" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 684a97f9456209609f00381df489b6dc17e329f4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30965)
* ff58bdbffdc38ea1af4fa5b270bef58fcfc0f74a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on pull request #18672: [FLINK-25996][runtime] Introduce job property isDynamicGraph to ExecutionConfig
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on pull request #18672:
URL: https://github.com/apache/flink/pull/18672#issuecomment-1033601158
Squash commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org