You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org> on 2026/01/08 07:30:50 UTC
[PR] fix fastavro read java avro issue [paimon]
XiaoHongbo-Hope opened a new pull request, #6982:
URL: https://github.com/apache/paimon/pull/6982
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2673127317
##########
paimon-python/dev/run_mixed_tests.sh:
##########
@@ -192,13 +192,77 @@ run_pk_dv_test() {
return 1
fi
}
+
+# Function to run zstd manifest e2e test
+run_zstd_manifest_test() {
Review Comment:
> You don't need to create this, by default, manifest is compressed by zstd.
Oh, It seems that the default compression is lz4 in python, is it by design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2674766605
##########
paimon-lance/src/test/java/org/apache/paimon/JavaPyLanceE2ETest.java:
##########
@@ -260,19 +261,9 @@ public void testJavaWriteReadPkTableLance() throws Exception {
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
> Why disable for 3.6?
py36 does not have pylance dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2673127317
##########
paimon-python/dev/run_mixed_tests.sh:
##########
@@ -192,13 +192,77 @@ run_pk_dv_test() {
return 1
fi
}
+
+# Function to run zstd manifest e2e test
+run_zstd_manifest_test() {
Review Comment:
> You don't need to create this, by default, manifest is compressed by zstd.
It seems that the default compression is lz4 in python, is it by design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix fastavro read java avro issue [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #6982:
URL: https://github.com/apache/paimon/pull/6982#issuecomment-3722968824
> We should add java & python e2e for 3.6 too.
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix fastavro read java avro issue [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope closed pull request #6982: fix fastavro read java avro issue
URL: https://github.com/apache/paimon/pull/6982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2674769166
##########
paimon-core/src/test/java/org/apache/paimon/JavaPyE2ETest.java:
##########
@@ -356,6 +357,7 @@ public void testPKDeletionVectorWriteMultiBatchRawConvertable() throws Exception
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
> Why disable for 3.6?
compatible issue in py36, will create another PR to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2674769166
##########
paimon-core/src/test/java/org/apache/paimon/JavaPyE2ETest.java:
##########
@@ -356,6 +357,7 @@ public void testPKDeletionVectorWriteMultiBatchRawConvertable() throws Exception
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
> Why disable for 3.6?
compatible issue in pk table for py36, will create another PR to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2674644640
##########
paimon-core/src/test/java/org/apache/paimon/JavaPyE2ETest.java:
##########
@@ -356,6 +357,7 @@ public void testPKDeletionVectorWriteMultiBatchRawConvertable() throws Exception
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
Why disable for 3.6?
##########
paimon-lance/src/test/java/org/apache/paimon/JavaPyLanceE2ETest.java:
##########
@@ -260,19 +261,9 @@ public void testJavaWriteReadPkTableLance() throws Exception {
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
Why disable for 3.6?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix fastavro read java avro issue [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #6982:
URL: https://github.com/apache/paimon/pull/6982#issuecomment-3722959037
We should add java & python e2e for 3.6 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2673127317
##########
paimon-python/dev/run_mixed_tests.sh:
##########
@@ -192,13 +192,77 @@ run_pk_dv_test() {
return 1
fi
}
+
+# Function to run zstd manifest e2e test
+run_zstd_manifest_test() {
Review Comment:
> You don't need to create this, by default, manifest is compressed by zstd.
It seems that the default compression is lz4 in python, is it by design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2674766605
##########
paimon-lance/src/test/java/org/apache/paimon/JavaPyLanceE2ETest.java:
##########
@@ -260,19 +261,9 @@ public void testJavaWriteReadPkTableLance() throws Exception {
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
> Why disable for 3.6?
py36 does not has pylance dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2674768305
##########
paimon-core/src/test/java/org/apache/paimon/JavaPyE2ETest.java:
##########
@@ -356,6 +357,7 @@ public void testPKDeletionVectorWriteMultiBatchRawConvertable() throws Exception
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
> Why disable for 3.6?
has bug in py36, will fix in another seperate PR.
##########
paimon-core/src/test/java/org/apache/paimon/JavaPyE2ETest.java:
##########
@@ -356,6 +357,7 @@ public void testPKDeletionVectorWriteMultiBatchRawConvertable() throws Exception
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
> Why disable for 3.6?
has bug in py36, will fix in another seperate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #6982:
URL: https://github.com/apache/paimon/pull/6982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2672828891
##########
paimon-python/dev/run_mixed_tests.sh:
##########
@@ -192,13 +192,77 @@ run_pk_dv_test() {
return 1
fi
}
+
+# Function to run zstd manifest e2e test
+run_zstd_manifest_test() {
Review Comment:
You don't need to create this, by default, manifest is compressed by zstd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #6982:
URL: https://github.com/apache/paimon/pull/6982#issuecomment-3724355475
> We should add java & python e2e for 3.6 too.
When I enable e2e case for python 3.6, some cases failed. Then I add only current case in this PR only, will create another PR to fix other cases in python 3.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #6982:
URL: https://github.com/apache/paimon/pull/6982#discussion_r2674769166
##########
paimon-core/src/test/java/org/apache/paimon/JavaPyE2ETest.java:
##########
@@ -356,6 +357,7 @@ public void testPKDeletionVectorWriteMultiBatchRawConvertable() throws Exception
@Test
@EnabledIfSystemProperty(named = "run.e2e.tests", matches = "true")
+ @DisabledIfSystemProperty(named = "python.version", matches = "3.6")
Review Comment:
> Why disable for 3.6?
has bug in py36, will create another seperate PR to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [python/hotfix] Fix zstd manifest decompression error on Python 3.6 [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #6982:
URL: https://github.com/apache/paimon/pull/6982#issuecomment-3727236581
Thanks @XiaoHongbo-Hope , looks good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org