You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Jakob Homan (Jira)" <ji...@apache.org> on 2019/09/13 22:23:00 UTC
[jira] [Created] (AIRFLOW-5489) bash_senor: Remove unneeded
assignment of variable
Jakob Homan created AIRFLOW-5489:
------------------------------------
Summary: bash_senor: Remove unneeded assignment of variable
Key: AIRFLOW-5489
URL: https://issues.apache.org/jira/browse/AIRFLOW-5489
Project: Apache Airflow
Issue Type: Bug
Components: operators
Affects Versions: 1.10.6
Reporter: Jakob Homan
Note: This ticket's being created to facilitate a new contributor's workshop for Airflow. After the workshop has completed, I'll mark these all available for anyone that might like to take them on.
The `line` variable is assigned to `''` but then immediately reassigned in the loop. This first assignment should be deleted.
airflow/contrib/sensors/bash_sensor.py:83
{code:java}
line = ''
for line in iter(sp.stdout.readline, b''):
line = line.decode(self.output_encoding).strip()
self.log.info(line)
sp.wait()
self.log.info("Command exited with return code %s", sp.returncode) {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)