You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2023/08/21 01:42:20 UTC
[GitHub] [struts] dependabot[bot] opened a new pull request, #734: Bump opensymphony:sitemesh from 2.4.2 to 2.5.0
dependabot[bot] opened a new pull request, #734:
URL: https://github.com/apache/struts/pull/734
Bumps [opensymphony:sitemesh](https://github.com/sitemesh/sitemesh2) from 2.4.2 to 2.5.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sitemesh/sitemesh2/releases">opensymphony:sitemesh's releases</a>.</em></p>
<blockquote>
<h2>2.5.0</h2>
<p>This is the first official release since 2.4.x that incorporates the use of <a href="https://github.com/sitemesh/sitemesh2/blob/2.5.0/src/java/com/opensymphony/module/sitemesh/SitemeshBuffer.java"><code>SiteMeshBuffer</code></a> which contains the various <a href="https://github.com/sitemesh/sitemesh2/blob/2.5.0/src/java/com/opensymphony/module/sitemesh/SitemeshBufferFragment.java"><code>SiteMeshBufferFragment</code></a>s used in a page. This release is breaking for any frameworks such as Grails that extend the functionality of <a href="https://github.com/sitemesh/sitemesh2/blob/2.5.0/src/java/com/opensymphony/module/sitemesh/parser/AbstractPage.java"><code>AbstractPage</code></a> due to SitemeshBuffer being required during initialization (e.g. <a href="https://github.com/grails/grails-gsp/blob/v6.0.1/grails-web-sitemesh/src/main/groovy/org/grails/web/sitemesh/GSPSitemeshPage.java"><code>GrailsGSPPage</code></a>). Frameworks such as Grails that incorporate their own buffer im
plementation can update by implementing their own <a href="https://github.com/sitemesh/sitemesh2/blob/2.5.0/src/java/com/opensymphony/module/sitemesh/SitemeshBuffer.java"><code>SitemeshBuffer</code></a> interface or choose to use <a href="https://github.com/sitemesh/sitemesh2/blob/2.5.0/src/java/com/opensymphony/module/sitemesh/DefaultSitemeshBuffer.java"><code>DefaultSitemeshBuffer</code></a> instead. For example, Grails would use it's own <a href="https://github.com/grails/grails-core/blob/v6.0.0/grails-encoder/src/main/groovy/org/grails/buffer/StreamCharBuffer.java"><code>StreamCharBuffer</code></a> instead of <a href="https://github.com/sitemesh/sitemesh2/blob/2.5.0/src/java/com/opensymphony/module/sitemesh/SitemeshBuffer.java"><code>SitemeshBufferFragment</code></a>.</p>
<h2>What's Changed</h2>
<ul>
<li>Buffering and <a href="https://github.com/sitemesh/sitemesh2/blob/2.5.0/src/java/com/opensymphony/module/sitemesh/scalability/secondarystorage/SecondaryStorage.java">SecondaryStorage</a> support.</li>
<li>Fixes issue <a href="https://redirect.github.com/sitemesh/sitemesh2/issues/18">#18</a> by <a href="https://github.com/yortx"><code>@yortx</code></a> in <a href="https://redirect.github.com/sitemesh/sitemesh2/pull/19">sitemesh/sitemesh2#19</a></li>
<li>com.opensymphony.module.sitemesh.Factory no longer works with Java 11 by <a href="https://github.com/ebourg"><code>@ebourg</code></a> in <a href="https://redirect.github.com/sitemesh/sitemesh2/pull/36">sitemesh/sitemesh2#36</a></li>
<li>fix rendering for script/comment/CDATA inside content tags in FastPageParser.java by <a href="https://github.com/jtodt"><code>@jtodt</code></a> in <a href="https://redirect.github.com/sitemesh/sitemesh2/pull/33">sitemesh/sitemesh2#33</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/yortx"><code>@yortx</code></a> made their first contribution in <a href="https://redirect.github.com/sitemesh/sitemesh2/pull/19">sitemesh/sitemesh2#19</a></li>
<li><a href="https://github.com/ebourg"><code>@ebourg</code></a> made their first contribution in <a href="https://redirect.github.com/sitemesh/sitemesh2/pull/36">sitemesh/sitemesh2#36</a></li>
<li><a href="https://github.com/jtodt"><code>@jtodt</code></a> made their first contribution in <a href="https://redirect.github.com/sitemesh/sitemesh2/pull/33">sitemesh/sitemesh2#33</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/sitemesh/sitemesh2/compare/2.4.2...2.5.0">https://github.com/sitemesh/sitemesh2/compare/2.4.2...2.5.0</a></p>
<p>Thank you everyone who made significant contributions to this release:</p>
<ul>
<li><a href="https://github.com/jroper"><code>@jroper</code></a></li>
<li><a href="https://github.com/bbakerman"><code>@bbakerman</code></a></li>
</ul>
<h2>2.4.4</h2>
<p>This release just contains a minor patch. Specifically it has <code>TokenizedHTMLPage</code> use a <code>PrintWriter</code> (if available) instead of using the <code>toString()</code></p>
<p>The Java Documentation was also fixed and distributed to Maven Central so it renders correctly.</p>
<p><strong>Full Changelog</strong>: <a href="https://github.com/sitemesh/sitemesh2/compare/2.4.3...2.4.4">https://github.com/sitemesh/sitemesh2/compare/2.4.3...2.4.4</a></p>
<h2>2.4.3</h2>
<p><strong>Full Changelog</strong>: <a href="https://github.com/sitemesh/sitemesh2/compare/2.4.2...2.4.3">https://github.com/sitemesh/sitemesh2/compare/2.4.2...2.4.3</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/sitemesh/sitemesh2/blob/master/CHANGES.txt">opensymphony:sitemesh's changelog</a>.</em></p>
<blockquote>
<hr />
<h2>-- Changes in 2.5 --</h2>
<ul>
<li>Single buffer parsing. This is supported by the HTMLPageParser and the PartialPageParser, and means
that the parsing process will never copy the content into another buffer, thus increasing
performance and reducing the amount of garbage the garbage collector has to clean up after a parsing</li>
<li>Buffer chaining. This allows multiple nested decorators (for example, using the JSP tags) to not
need to rebuffer or reparse the HTML of the chained buffer.</li>
<li>PartialPageParser that only parses the <!-- raw HTML omitted --> section of bodies. This is a very high performance
buffer for simple sitemesh use cases, that don't need any content extracted from the body. It stops
parsing as soon as it reaches the first body tag, and then scans from the end of the content to find
the end body tag, and treats everything in between as the body. Does not allow many of the advanced
features of Sitemesh to be used, such as filters and and <!-- raw HTML omitted --> tags. To use the partial page
parser, set the the pageParser in sitemesh.xml to be com.opensymphony.module.sitemesh.parser.PartialPageParser</li>
</ul>
<hr />
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/ef7aa0728eb5e4c4d468e763122543879df54c41"><code>ef7aa07</code></a> 2.5.0</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/baa35d97e2972b495caeef62e7411a227f3e9063"><code>baa35d9</code></a> Fix javadoc errors.</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/57f8422836cf0b8b44bcc3730011d6db4c8aaa35"><code>57f8422</code></a> Update README.md</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/37d8c836ef2bdd0b8b4852eccf313fcbff3f8193"><code>37d8c83</code></a> Update README.md</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/6835b4c3439e3ddbfefcf24d96ef5252b65af9b9"><code>6835b4c</code></a> Update README.md</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/bccdc097c614181b17c0b7268d9ab60d6ed009af"><code>bccdc09</code></a> Fix mockito unit test</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/5b31f34b1c7d84325323997f0ba3c01363c276b5"><code>5b31f34</code></a> Merge branch 'master' into atlassian</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/cd5710619c34242b3bf5cbf09e7e4aff3de32b28"><code>cd57106</code></a> Merge branch 'master' into atlassian</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/f493216acd92c98b404979f0610bf65ef47ff77a"><code>f493216</code></a> Update README.md 2.4.3</li>
<li><a href="https://github.com/sitemesh/sitemesh2/commit/c22782e778ff1fca00a21e5a54b76cc96e039e5d"><code>c22782e</code></a> README cleanup</li>
<li>Additional commits viewable in <a href="https://github.com/sitemesh/sitemesh2/compare/2.4.2...2.5.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] sepe81 commented on pull request #734: Bump opensymphony:sitemesh from 2.4.2 to 2.5.0
Posted by "sepe81 (via GitHub)" <gi...@apache.org>.
sepe81 commented on PR #734:
URL: https://github.com/apache/struts/pull/734#issuecomment-1695959576
Removing the deprecation sounds great b/c there seems to be some activity again, so that sitemesh is not dead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #734: Bump opensymphony:sitemesh from 2.4.2 to 2.5.0
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #734:
URL: https://github.com/apache/struts/pull/734#issuecomment-1704077385
It will happen in 6.4.0 https://issues.apache.org/jira/browse/WW-5344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump opensymphony:sitemesh from 2.4.2 to 2.5.0 [struts]
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk closed pull request #734: Bump opensymphony:sitemesh from 2.4.2 to 2.5.0
URL: https://github.com/apache/struts/pull/734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump opensymphony:sitemesh from 2.4.2 to 2.5.0 [struts]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #734:
URL: https://github.com/apache/struts/pull/734#issuecomment-1758044223
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #734: Bump opensymphony:sitemesh from 2.4.2 to 2.5.0
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart commented on PR #734:
URL: https://github.com/apache/struts/pull/734#issuecomment-1695687264
> Tried it with struts2-sitemesh-plugin in our webapp and faced no problems.
Thanks a lot! We should reconsider un-deprecate the plugin though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org