[GitHub] cloud-fan commented on a change in pull request #18576: [SPARK-21351][SQL] Update nullability based on children's output

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #18576: [SPARK-21351][SQL] Update nullability based on children's output
URL: https://github.com/apache/spark/pull/18576#discussion_r244007241
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -153,7 +153,9 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)
       RewritePredicateSubquery,
       ColumnPruning,
       CollapseProject,
-      RemoveRedundantProject)
+      RemoveRedundantProject) :+
+    Batch("UpdateAttributeReferences", Once,
+      UpdateNullabilityInAttributeReferences)
 
 Review comment:
   I noticed that this rule is very similar to `FixNullability`. Do we have to keep both of them? cc @maropu @gatorsmile 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org