You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/05 16:07:50 UTC

[GitHub] [apisix] tzssangglass commented on issue #6021: bug: in Orchestration, OpenID-Connect Plug-in Properties Timeout does not set, there will be an error

tzssangglass commented on issue #6021:
URL: https://github.com/apache/apisix/issues/6021#issuecomment-1005860080


   `conf.timeout` has default value, see: https://github.com/apache/apisix/blob/3f66fab63ecffa7bf4d5bdb02ce8a688a4285709/apisix/plugins/openid-connect.lua#L41-L46
   
   can you add a log like this:
   
   ```diff
   diff --git a/apisix/plugins/openid-connect.lua b/apisix/plugins/openid-connect.lua
   index 1c8d78c1..085581c8 100644
   --- a/apisix/plugins/openid-connect.lua
   +++ b/apisix/plugins/openid-connect.lua
   @@ -240,6 +240,7 @@ function _M.rewrite(plugin_conf, ctx)
    
        -- Previously, we multiply conf.timeout before storing it in etcd.
        -- If the timeout is too large, we should not multiply it again.
   +    ngx.log(ngx.WARN, "conf : ", require("inspect")(conf))
        if not (conf.timeout >= 1000 and conf.timeout % 1000 == 0) then
            conf.timeout = conf.timeout * 1000
        end
   diff --git a/t/toolkit b/t/toolkit
   index ab2471cc..94f471d3 160000
   --- a/t/toolkit
   +++ b/t/toolkit
   @@ -1 +1 @@
   -Subproject commit ab2471cc9cbeec6fe605120160eeb9dd17ddda2c
   +Subproject commit 94f471d3a9045667bc1f1784a21f89315cd64f7e
   ```
   
   And you need to provide more complete reproduction of the steps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org