You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Xiaoyu Yao (JIRA)" <ji...@apache.org> on 2015/06/19 00:30:01 UTC
[jira] [Commented] (HDFS-8192) Eviction should key off used locked
memory instead of ram disk free space
[ https://issues.apache.org/jira/browse/HDFS-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592653#comment-14592653 ]
Xiaoyu Yao commented on HDFS-8192:
----------------------------------
Thanks for fixing this, [~arpitagarwal]. +1 for the v03 patch, which looks pretty good to me.
Only one suggestion:
Can you add some comment in FSDataSetImpl#evictBlocks() regarding how the cache usage is decremented upon eviction? It takes me a while to figure it out in FsVolumeImpl#OnBlockFileDeletion().
> Eviction should key off used locked memory instead of ram disk free space
> -------------------------------------------------------------------------
>
> Key: HDFS-8192
> URL: https://issues.apache.org/jira/browse/HDFS-8192
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-8192.01.patch, HDFS-8192.02.patch, HDFS-8192.03.patch
>
>
> Eviction from RAM disk will be triggered when locked memory is insufficient RAM to allocate a new replica for writing.
> This is a follow up to HDFS-8157. We no longer need the threshold configuration keys since we won't be evicting based on thresholds any more.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)