You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2019/12/04 13:03:51 UTC

[isis] 07/08: ISIS-2212: uses class literals in WebModuleShiro where possible

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git

commit 8558c5e3a293f87ce347c913fc1e05c5dc5f2af4
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Wed Dec 4 12:53:56 2019 +0000

    ISIS-2212: uses class literals in WebModuleShiro where possible
---
 .../main/java/org/apache/isis/security/shiro/WebModuleShiro.java | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/core/security/shiro/src/main/java/org/apache/isis/security/shiro/WebModuleShiro.java b/core/security/shiro/src/main/java/org/apache/isis/security/shiro/WebModuleShiro.java
index 6893ee7..635d343 100644
--- a/core/security/shiro/src/main/java/org/apache/isis/security/shiro/WebModuleShiro.java
+++ b/core/security/shiro/src/main/java/org/apache/isis/security/shiro/WebModuleShiro.java
@@ -33,6 +33,7 @@ import org.apache.shiro.web.env.EnvironmentLoaderListener;
 import org.apache.shiro.web.env.IniWebEnvironment;
 import org.apache.shiro.web.env.WebEnvironment;
 import org.apache.shiro.web.filter.mgt.PathMatchingFilterChainResolver;
+import org.apache.shiro.web.servlet.ShiroFilter;
 import org.springframework.core.Ordered;
 import org.springframework.core.annotation.Order;
 import org.springframework.stereotype.Service;
@@ -61,12 +62,8 @@ import lombok.val;
 @Service @Order(Ordered.HIGHEST_PRECEDENCE + 100)
 public final class WebModuleShiro implements WebModule  {
     
-    private final static String SHIRO_LISTENER_CLASS_NAME = 
-            //"org.apache.shiro.web.env.EnvironmentLoaderListener";
-            EnvironmentLoaderListenerForIsis.class.getName();
-
-    private final static String SHIRO_FILTER_CLASS_NAME = 
-            "org.apache.shiro.web.servlet.ShiroFilter";
+    private final static String SHIRO_LISTENER_CLASS_NAME = EnvironmentLoaderListenerForIsis.class.getName();
+    private final static String SHIRO_FILTER_CLASS_NAME = ShiroFilter.class.getName();
 
     private final static String SHIRO_FILTER_NAME = "ShiroFilter";