embedded tc

[Keith Wannamaker <Ke...@Wannamaker.org>]

Could this ever happen or am I doing something silly?
Keith

Index: src/share/org/apache/tomcat/startup/EmbededTomcat.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/startup/EmbededTomcat.java,
v
retrieving revision 1.50
diff -u -b -r1.50 EmbededTomcat.java
--- src/share/org/apache/tomcat/startup/EmbededTomcat.java      2001/08/23
15:13:47     1.50
+++ src/share/org/apache/tomcat/startup/EmbededTomcat.java      2001/08/29
00:46:50
@@ -705,7 +705,9 @@
        String cp=System.getProperty("tc_path_add");
        cp=IntrospectionUtils.classPathAdd(commonCP,cp);
        cp=IntrospectionUtils.classPathAdd(appsCP,cp);
+       if (cp != null) {
        System.getProperties().put("tc_path_add",cp);
+       }

        contextM.setParentLoader(parentCL);
        contextM.setCommonLoader(commonCL);

Re: embedded tc

[Christopher Cain <cc...@mhsoftware.com>]

Quoting Keith Wannamaker <Ke...@Wannamaker.org>:

> Could this ever happen or am I doing something silly?
> Keith

[snip]

> +       if (cp != null) {
>         System.getProperties().put("tc_path_add",cp);
> +       }

Not sure if it could possibly happen or not. Just to add my $.02 to the above, 
however, it might be good to have an "else" clause either toss a message to the 
command-line (if skipping the put() call might cause problems later on down the 
line) or write a message to log (if it's not that big of a deal).

- Christopher

/**
 * Pleurez, pleurez, mes yeux, et fondez vous en eau!
 * La moitié de ma vie a mis l'autre au tombeau.
 *    ---Cornelle
 */