You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "omar-faruk (via GitHub)" <gi...@apache.org> on 2024/04/05 22:05:28 UTC
[PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller.and I2s pin selection range fixed [nuttx]
omar-faruk opened a new pull request, #12076:
URL: https://github.com/apache/nuttx/pull/12076
## Summary
1. ESP32S3 GPIO pin 19 or 20 by default connected to USB/JTAG controller. When using pin 19 or 20 as GPIO, disable USB/JTAG
2. arch/xtensa/src/esp32s3/Kconfig updated: I2S BCLK, WSPIN, DINPIN, DOUTPIN pin range changed to 0 48
## Impact
pin 19, 20 can be used for other purposes.
pins > 33 can now be used for I2S0 and I2S1 in ESP32S3
## Testing
Tested on ESP32S3-WROOM-1, ESP32S3-MINI-1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller and I2S pin selection range fixed [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12076:
URL: https://github.com/apache/nuttx/pull/12076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller and I2S pin selection range fixed [nuttx]
Posted by "omar-faruk (via GitHub)" <gi...@apache.org>.
omar-faruk commented on code in PR #12076:
URL: https://github.com/apache/nuttx/pull/12076#discussion_r1554647647
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -366,26 +366,26 @@ config ESP32S3_I2S0_SAMPLE_RATE
config ESP32S3_I2S0_BCLKPIN
int "I2S0 BCLK pin"
default 4
- range 0 33 if ESP32S3_I2S0_ROLE_MASTER
- range 0 39 if ESP32S3_I2S0_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S0_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S0_ROLE_SLAVE
Review Comment:
Sorry, I could not understand. Shall I create a different pull request for the range 0-48?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller and I2S pin selection range fixed [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12076:
URL: https://github.com/apache/nuttx/pull/12076#discussion_r1554655469
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -366,26 +366,26 @@ config ESP32S3_I2S0_SAMPLE_RATE
config ESP32S3_I2S0_BCLKPIN
int "I2S0 BCLK pin"
default 4
- range 0 33 if ESP32S3_I2S0_ROLE_MASTER
- range 0 39 if ESP32S3_I2S0_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S0_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S0_ROLE_SLAVE
Review Comment:
both ESP32S3_I2S0_ROLE_MASTER and ESP32S3_I2S0_ROLE_SLAVE have the same range in your patch, why not just change to `range 0 48` without if condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ESP32S3 configuring gpio pin 19 or 20 ( USB_D+/- ) for purposes other than USB/JTAG Controller and I2S pin selection range fixed [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12076:
URL: https://github.com/apache/nuttx/pull/12076#discussion_r1554526338
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -366,26 +366,26 @@ config ESP32S3_I2S0_SAMPLE_RATE
config ESP32S3_I2S0_BCLKPIN
int "I2S0 BCLK pin"
default 4
- range 0 33 if ESP32S3_I2S0_ROLE_MASTER
- range 0 39 if ESP32S3_I2S0_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S0_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S0_ROLE_SLAVE
config ESP32S3_I2S0_WSPIN
int "I2S0 WS pin"
default 5
- range 0 33 if ESP32S3_I2S0_ROLE_MASTER
- range 0 39 if ESP32S3_I2S0_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S0_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S0_ROLE_SLAVE
Review Comment:
merge to `range 0 48`
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -478,26 +478,26 @@ config ESP32S3_I2S1_SAMPLE_RATE
config ESP32S3_I2S1_BCLKPIN
int "I2S1 BCLK pin"
default 22
- range 0 33 if ESP32S3_I2S1_ROLE_MASTER
- range 0 39 if ESP32S3_I2S1_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S1_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S1_ROLE_SLAVE
config ESP32S3_I2S1_WSPIN
int "I2S1 WS pin"
default 23
- range 0 33 if ESP32S3_I2S1_ROLE_MASTER
- range 0 39 if ESP32S3_I2S1_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S1_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S1_ROLE_SLAVE
Review Comment:
merge to `range 0 48`
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -478,26 +478,26 @@ config ESP32S3_I2S1_SAMPLE_RATE
config ESP32S3_I2S1_BCLKPIN
int "I2S1 BCLK pin"
default 22
- range 0 33 if ESP32S3_I2S1_ROLE_MASTER
- range 0 39 if ESP32S3_I2S1_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S1_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S1_ROLE_SLAVE
Review Comment:
merge to `range 0 48`
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -366,26 +366,26 @@ config ESP32S3_I2S0_SAMPLE_RATE
config ESP32S3_I2S0_BCLKPIN
int "I2S0 BCLK pin"
default 4
- range 0 33 if ESP32S3_I2S0_ROLE_MASTER
- range 0 39 if ESP32S3_I2S0_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S0_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S0_ROLE_SLAVE
Review Comment:
merge to `range 0 48`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org