You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/25 21:50:34 UTC
[GitHub] [beam] ibzib commented on a change in pull request #13660: [BEAM-10961] Enable strict dependency on Google Cloud Dataflow runner
ibzib commented on a change in pull request #13660:
URL: https://github.com/apache/beam/pull/13660#discussion_r561200509
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -78,18 +79,25 @@ dependencies {
compile library.java.google_api_client
compile library.java.google_api_services_clouddebugger
compile library.java.google_api_services_dataflow
- compile library.java.google_api_services_storage
+ testImplementation 'com.google.apis:google-api-services-storage:v1-rev20200611-1.30.10'
compile library.java.google_auth_library_credentials
compile library.java.google_auth_library_oauth2_http
compile library.java.google_http_client
- compile library.java.google_http_client_jackson2
+ testImplementation 'com.google.http-client:google-http-client-jackson2:1.34.0'
compile library.java.jackson_annotations
compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.slf4j_api
compile library.java.vendored_grpc_1_26_0
- testCompile library.java.hamcrest_core
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.hamcrest:hamcrest:2.1"
+ compile "com.google.auth:google-auth-library-credentials:0.19.0"
+ permitUnusedDeclared "com.google.guava:guava:25.1-jre"
+ permitUnusedDeclared "io.opencensus:opencensus-api:0.24.0"
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
```suggestion
```
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -85,24 +87,34 @@ dependencies {
compile google_api_services_dataflow
compile library.java.avro
compile library.java.google_api_client
+ permitUnusedDeclared library.java.google_api_client // BEAM-11761
+ compile library.java.google_auth_library_credentials
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
compile library.java.jackson_annotations
compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
+ compile library.java.proto_google_common_protos
shadow library.java.vendored_guava_26_0_jre
compile library.java.slf4j_api
+ compile "io.opencensus:opencensus-api:0.28.0"
+ compile "org.conscrypt:conscrypt-openjdk-uber:2.5.1"
+ compile "com.google.guava:guava:25.1-jre"
Review comment:
```suggestion
compile guava
```
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -85,24 +87,34 @@ dependencies {
compile google_api_services_dataflow
compile library.java.avro
compile library.java.google_api_client
+ permitUnusedDeclared library.java.google_api_client // BEAM-11761
+ compile library.java.google_auth_library_credentials
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
compile library.java.jackson_annotations
compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
+ compile library.java.proto_google_common_protos
shadow library.java.vendored_guava_26_0_jre
compile library.java.slf4j_api
+ compile "io.opencensus:opencensus-api:0.28.0"
+ compile "org.conscrypt:conscrypt-openjdk-uber:2.5.1"
+ compile "com.google.guava:guava:25.1-jre"
compile "javax.servlet:javax.servlet-api:3.1.0"
// Conscrypt shouldn't be included here because Conscrypt won't work when being shaded.
// (Context: https://github.com/apache/beam/pull/13846)
// Conscrypt will be added to runtime dependencies by GrpcVendoring so compileOnly works for now.
compileOnly "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
+ permitUnusedDeclared "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64" // BEAM-11761
Review comment:
It looks like this dependency was modified recently. @veblush @kennknowles I couldn't follow the reasoning behind #13846. I have two questions here:
1. How are `conscrypt-openjdk` and `conscrypt-openjdk-uber` related?
2. Why do we need `conscrypt-openjdk`, since it's compileOnly yet the plugin is telling us we don't need it for Java compilation?
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -79,17 +81,19 @@ dependencies {
compile library.java.google_api_services_clouddebugger
compile library.java.google_api_services_dataflow
compile library.java.google_api_services_storage
+ permitUnusedDeclared library.java.google_api_services_storage // BEAM-11761
compile library.java.google_auth_library_credentials
compile library.java.google_auth_library_oauth2_http
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
+ permitUnusedDeclared library.java.google_http_client_jackson2 // BEAM-11761
compile library.java.jackson_annotations
compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.slf4j_api
compile library.java.vendored_grpc_1_26_0
- testCompile library.java.hamcrest_core
+ compile "org.hamcrest:hamcrest:2.1"
Review comment:
I saw you a `hamcrest` library in one of your other PRs. We can merge that one first, and then update this one.
```suggestion
compile hamcrest
```
##########
File path: runners/google-cloud-dataflow-java/worker/legacy-worker/build.gradle
##########
@@ -211,8 +213,18 @@ dependencies {
// (Context: https://github.com/apache/beam/pull/13846)
// Conscrypt will be added to runtime dependencies by GrpcVendoring so compileOnly works for now.
compileOnly "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64"
+ permitUnusedDeclared "org.conscrypt:conscrypt-openjdk:2.5.1:linux-x86_64" // BEAM-11761
+ compile "javax.servlet:javax.servlet-api:3.1.0"
+ compile "org.conscrypt:conscrypt-openjdk-uber:1.3.0"
Review comment:
```suggestion
compile "org.conscrypt:conscrypt-openjdk-uber:2.5.1"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org