You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by anuragmath <gi...@git.apache.org> on 2016/04/07 12:49:03 UTC
[GitHub] incubator-fineract pull request: Loan Product Office Name Paramete...
GitHub user anuragmath opened a pull request:
https://github.com/apache/incubator-fineract/pull/65
Loan Product Office Name Parameter
For Those who needs to have account number format as
Office_Name = as Stripped with Initial Letters,
Product_short_name = concatenating both OFFICE_NAME + PRODUCT SHORT NAME
This kind of series will be useful for MFI/NBFC and Integrator, to utilize this new kind of AccountNumberGeneration
@theupscale
From Upscale Team
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anuragmath/incubator-fineract NewAccountNumberParameter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit e09b702cd68b9c2f7509612a8d7ec20e24ea9f38
Author: anuragmath <an...@theupscale.in>
Date: 2016-04-07T10:35:52Z
Loan_Product_Office_Name_Parameter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request: Loan Product Office Name Paramete...
Posted by anuragmath <gi...@git.apache.org>.
Github user anuragmath commented on the pull request:
https://github.com/apache/incubator-fineract/pull/65#issuecomment-214630555
can u please tell me how can i know about the merge conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request: Loan Product Office Name Paramete...
Posted by anuragmath <gi...@git.apache.org>.
Github user anuragmath commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/65#discussion_r59515825
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java ---
@@ -62,6 +63,7 @@ public String generate(Loan loan, AccountNumberFormat accountNumberFormat) {
propertyMap.put(ID, loan.getId().toString());
propertyMap.put(OFFICE_NAME, loan.getOffice().getName());
propertyMap.put(LOAN_PRODUCT_SHORT_NAME, loan.loanProduct().getShortName());
+ propertyMap.put(OFFICE_AND_LOAD_PRODUCT_NAME, loan.getOffice().getName()+ loan.loanProduct().getShortName());
--- End diff --
thanks for pointing out that. I have corrected it and made it necessary now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request: Loan Product Office Name Paramete...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the pull request:
https://github.com/apache/incubator-fineract/pull/65#issuecomment-214622956
Changes looks OK. But this pull request is having conflicts. Can you please resolve merge conflicts and send a pull request with a single commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request: Loan Product Office Name Paramete...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the pull request:
https://github.com/apache/incubator-fineract/pull/65#issuecomment-214636806
I assume your git remote name is upstream.
Run these two commands
git fetch upstream
git rebase upstream/develop
It will get the latest code and try to merge with your changes. If merge fails, it will show the files with conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request: Loan Product Office Name Paramete...
Posted by rajuan <gi...@git.apache.org>.
Github user rajuan commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/65#discussion_r59498993
--- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java ---
@@ -62,6 +63,7 @@ public String generate(Loan loan, AccountNumberFormat accountNumberFormat) {
propertyMap.put(ID, loan.getId().toString());
propertyMap.put(OFFICE_NAME, loan.getOffice().getName());
propertyMap.put(LOAN_PRODUCT_SHORT_NAME, loan.loanProduct().getShortName());
+ propertyMap.put(OFFICE_AND_LOAD_PRODUCT_NAME, loan.getOffice().getName()+ loan.loanProduct().getShortName());
--- End diff --
This property is never read again... looks unnecessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---