[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2585: Add max_dyn and min_dyn for max/min for dictionary array

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2585:
URL: https://github.com/apache/arrow-rs/pull/2585#discussion_r954542354


##########
arrow/src/compute/kernels/aggregate.rs:
##########
@@ -215,6 +215,68 @@ where
     }
 }
 
+/// Returns the min of values in the array.
+pub fn min_dyn<T, A: ArrayAccessor<Item = T::Native>>(array: A) -> Option<T::Native>

Review Comment:
   Typically the _dyn kernels take a trait object, these don't appear to. Perhaps we could choose a different name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org