You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Michael Brohl <mi...@ecomify.de> on 2016/09/04 11:47:32 UTC
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name
This might disappear in the many notifications so I'd like to asked the
below question also here in the dev list.
What do you think?
Thanks,
Michael Brohl
ecomify GmbH
www.ecomify.de
Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15462791#comment-15462791 ]
>
> Michael Brohl commented on OFBIZ-8045:
> --------------------------------------
>
> I think about doing these changes and all the other similar ones in one single commit and not issue by issue, what do others think about this?
>
>> Accounting: Consistent form name
>> --------------------------------
>>
>> Key: OFBIZ-8045
>> URL: https://issues.apache.org/jira/browse/OFBIZ-8045
>> Project: OFBiz
>> Issue Type: Sub-task
>> Components: accounting
>> Reporter: Tanmay Muley
>> Assignee: Michael Brohl
>> Priority: Minor
>> Fix For: Trunk
>>
>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch, OFBIZ-8045.patch
>>
>>
>> Change all form names to upper camel case for consistency.
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name
Posted by Michael Brohl <mi...@ecomify.de>.
Thanks, Jacques,
I will do the work during our Community Day so we'll have some time to
wait for additional comments.
Regards,
Michael Brohl
ecomify GmbH
www.ecomify.de
Am 05.09.16 um 13:51 schrieb Jacques Le Roux:
> Michael,
>
> I'd wait 2 days before applying a lazy consensus, ie if nobody chime
> in, please commit...
>
> Jacques
>
>
> Le 05/09/2016 à 13:40, Akash Jain a écrit :
>> +1 for the single commit!
>>
>> Thanks and Regards
>> --
>> Akash Jain
>>
>> On Mon, Sep 5, 2016 at 2:56 PM, Michael Brohl <mi...@ecomify.de>
>> wrote:
>>
>>> Thanks for your suggestions, Akash and Jacques.
>>>
>>> To be clear, my question is only for these specific changes which I
>>> plan
>>> do review and commit.
>>>
>>> They are all of the same nature, easy to review and a single commit
>>> would
>>> avoid to write a lot of similar commit messages, references to
>>> different
>>> revisions in Jira etc. It would be simply more efficient.
>>>
>>> This should not be applied as a general rule I think, I generally
>>> prefer
>>> more granular commits for different changes.
>>>
>>> Other opinions?
>>>
>>> Regards,
>>>
>>> Michael Brohl
>>> ecomify GmbH
>>> www.ecomify.de
>>>
>>>
>>> Am 05.09.16 um 11:00 schrieb Jacques Le Roux:
>>>
>>> BTW, this was not exactly Michael's question (apart your 1st point). We
>>>> can have several sub-tasks but commit all of them in one shoot.
>>>>
>>>> Others opinions? Anyway I don't think we can have a global
>>>> agreement (for
>>>> every Jiras) on this, because it really dependd on the content of the
>>>> subtasks patches.
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 05/09/2016 à 10:36, Jacques Le Roux a écrit :
>>>>
>>>>> Makes sense Akash, thanks!
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 05/09/2016 à 07:39, Akash Jain a écrit :
>>>>>
>>>>>> I think both ways are fine but personally I like to do this kind of
>>>>>> changes
>>>>>> component wise because,
>>>>>> -- it's easy to review
>>>>>> -- more users and committers can involve
>>>>>> -- easy for beginners to contribute
>>>>>>
>>>>>> Thanks and Regards
>>>>>> --
>>>>>> Akash Jain
>>>>>>
>>>>>> On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux <
>>>>>> jacques.le.roux@les7arts.com> wrote:
>>>>>>
>>>>>> I wonder, it would be a bit easier to commit but the review could be
>>>>>>> harder, a moot point I'd say
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
>>>>>>> Le 04/09/2016 à 13:47, Michael Brohl a écrit :
>>>>>>>
>>>>>>> This might disappear in the many notifications so I'd like to
>>>>>>> asked the
>>>>>>>> below question also here in the dev list.
>>>>>>>> What do you think?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Michael Brohl
>>>>>>>> ecomify GmbH
>>>>>>>> www.ecomify.de
>>>>>>>>
>>>>>>>> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>>>>>>>>
>>>>>>>> [
>>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.
>>>>>>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>>>>>>> l&focusedCommentId=15462791#comment-15462791 ]
>>>>>>>>>
>>>>>>>>> Michael Brohl commented on OFBIZ-8045:
>>>>>>>>> --------------------------------------
>>>>>>>>>
>>>>>>>>> I think about doing these changes and all the other similar
>>>>>>>>> ones in
>>>>>>>>> one
>>>>>>>>> single commit and not issue by issue, what do others think about
>>>>>>>>> this?
>>>>>>>>>
>>>>>>>>> Accounting: Consistent form name
>>>>>>>>>
>>>>>>>>>> --------------------------------
>>>>>>>>>>
>>>>>>>>>> Key: OFBIZ-8045
>>>>>>>>>> URL: https://issues.apache.org/jira
>>>>>>>>>> /browse/OFBIZ-8045
>>>>>>>>>> Project: OFBiz
>>>>>>>>>> Issue Type: Sub-task
>>>>>>>>>> Components: accounting
>>>>>>>>>> Reporter: Tanmay Muley
>>>>>>>>>> Assignee: Michael Brohl
>>>>>>>>>> Priority: Minor
>>>>>>>>>> Fix For: Trunk
>>>>>>>>>>
>>>>>>>>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch,
>>>>>>>>>> OFBIZ-8045.patch
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Change all form names to upper camel case for consistency.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> This message was sent by Atlassian JIRA
>>>>>>>>> (v6.3.4#6332)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>
>>>
>
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form
name
Posted by Jacques Le Roux <ja...@les7arts.com>.
Michael,
I'd wait 2 days before applying a lazy consensus, ie if nobody chime in, please commit...
Jacques
Le 05/09/2016 � 13:40, Akash Jain a �crit :
> +1 for the single commit!
>
> Thanks and Regards
> --
> Akash Jain
>
> On Mon, Sep 5, 2016 at 2:56 PM, Michael Brohl <mi...@ecomify.de>
> wrote:
>
>> Thanks for your suggestions, Akash and Jacques.
>>
>> To be clear, my question is only for these specific changes which I plan
>> do review and commit.
>>
>> They are all of the same nature, easy to review and a single commit would
>> avoid to write a lot of similar commit messages, references to different
>> revisions in Jira etc. It would be simply more efficient.
>>
>> This should not be applied as a general rule I think, I generally prefer
>> more granular commits for different changes.
>>
>> Other opinions?
>>
>> Regards,
>>
>> Michael Brohl
>> ecomify GmbH
>> www.ecomify.de
>>
>>
>> Am 05.09.16 um 11:00 schrieb Jacques Le Roux:
>>
>> BTW, this was not exactly Michael's question (apart your 1st point). We
>>> can have several sub-tasks but commit all of them in one shoot.
>>>
>>> Others opinions? Anyway I don't think we can have a global agreement (for
>>> every Jiras) on this, because it really dependd on the content of the
>>> subtasks patches.
>>>
>>> Jacques
>>>
>>>
>>> Le 05/09/2016 � 10:36, Jacques Le Roux a �crit :
>>>
>>>> Makes sense Akash, thanks!
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 05/09/2016 � 07:39, Akash Jain a �crit :
>>>>
>>>>> I think both ways are fine but personally I like to do this kind of
>>>>> changes
>>>>> component wise because,
>>>>> -- it's easy to review
>>>>> -- more users and committers can involve
>>>>> -- easy for beginners to contribute
>>>>>
>>>>> Thanks and Regards
>>>>> --
>>>>> Akash Jain
>>>>>
>>>>> On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux <
>>>>> jacques.le.roux@les7arts.com> wrote:
>>>>>
>>>>> I wonder, it would be a bit easier to commit but the review could be
>>>>>> harder, a moot point I'd say
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 04/09/2016 � 13:47, Michael Brohl a �crit :
>>>>>>
>>>>>> This might disappear in the many notifications so I'd like to asked the
>>>>>>> below question also here in the dev list.
>>>>>>> What do you think?
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Michael Brohl
>>>>>>> ecomify GmbH
>>>>>>> www.ecomify.de
>>>>>>>
>>>>>>> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>>>>>>>
>>>>>>> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.
>>>>>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>>>>>> l&focusedCommentId=15462791#comment-15462791 ]
>>>>>>>>
>>>>>>>> Michael Brohl commented on OFBIZ-8045:
>>>>>>>> --------------------------------------
>>>>>>>>
>>>>>>>> I think about doing these changes and all the other similar ones in
>>>>>>>> one
>>>>>>>> single commit and not issue by issue, what do others think about
>>>>>>>> this?
>>>>>>>>
>>>>>>>> Accounting: Consistent form name
>>>>>>>>
>>>>>>>>> --------------------------------
>>>>>>>>>
>>>>>>>>> Key: OFBIZ-8045
>>>>>>>>> URL: https://issues.apache.org/jira
>>>>>>>>> /browse/OFBIZ-8045
>>>>>>>>> Project: OFBiz
>>>>>>>>> Issue Type: Sub-task
>>>>>>>>> Components: accounting
>>>>>>>>> Reporter: Tanmay Muley
>>>>>>>>> Assignee: Michael Brohl
>>>>>>>>> Priority: Minor
>>>>>>>>> Fix For: Trunk
>>>>>>>>>
>>>>>>>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch,
>>>>>>>>> OFBIZ-8045.patch
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Change all form names to upper camel case for consistency.
>>>>>>>>>
>>>>>>>>>
>>>>>>>> --
>>>>>>>> This message was sent by Atlassian JIRA
>>>>>>>> (v6.3.4#6332)
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>
>>
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name
Posted by Akash Jain <ak...@hotwaxsystems.com>.
+1 for the single commit!
Thanks and Regards
--
Akash Jain
On Mon, Sep 5, 2016 at 2:56 PM, Michael Brohl <mi...@ecomify.de>
wrote:
> Thanks for your suggestions, Akash and Jacques.
>
> To be clear, my question is only for these specific changes which I plan
> do review and commit.
>
> They are all of the same nature, easy to review and a single commit would
> avoid to write a lot of similar commit messages, references to different
> revisions in Jira etc. It would be simply more efficient.
>
> This should not be applied as a general rule I think, I generally prefer
> more granular commits for different changes.
>
> Other opinions?
>
> Regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 05.09.16 um 11:00 schrieb Jacques Le Roux:
>
> BTW, this was not exactly Michael's question (apart your 1st point). We
>> can have several sub-tasks but commit all of them in one shoot.
>>
>> Others opinions? Anyway I don't think we can have a global agreement (for
>> every Jiras) on this, because it really dependd on the content of the
>> subtasks patches.
>>
>> Jacques
>>
>>
>> Le 05/09/2016 à 10:36, Jacques Le Roux a écrit :
>>
>>> Makes sense Akash, thanks!
>>>
>>> Jacques
>>>
>>>
>>> Le 05/09/2016 à 07:39, Akash Jain a écrit :
>>>
>>>> I think both ways are fine but personally I like to do this kind of
>>>> changes
>>>> component wise because,
>>>> -- it's easy to review
>>>> -- more users and committers can involve
>>>> -- easy for beginners to contribute
>>>>
>>>> Thanks and Regards
>>>> --
>>>> Akash Jain
>>>>
>>>> On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux <
>>>> jacques.le.roux@les7arts.com> wrote:
>>>>
>>>> I wonder, it would be a bit easier to commit but the review could be
>>>>> harder, a moot point I'd say
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 04/09/2016 à 13:47, Michael Brohl a écrit :
>>>>>
>>>>> This might disappear in the many notifications so I'd like to asked the
>>>>>> below question also here in the dev list.
>>>>>> What do you think?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Michael Brohl
>>>>>> ecomify GmbH
>>>>>> www.ecomify.de
>>>>>>
>>>>>> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>>>>>>
>>>>>> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.
>>>>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>>>>> l&focusedCommentId=15462791#comment-15462791 ]
>>>>>>>
>>>>>>> Michael Brohl commented on OFBIZ-8045:
>>>>>>> --------------------------------------
>>>>>>>
>>>>>>> I think about doing these changes and all the other similar ones in
>>>>>>> one
>>>>>>> single commit and not issue by issue, what do others think about
>>>>>>> this?
>>>>>>>
>>>>>>> Accounting: Consistent form name
>>>>>>>
>>>>>>>> --------------------------------
>>>>>>>>
>>>>>>>> Key: OFBIZ-8045
>>>>>>>> URL: https://issues.apache.org/jira
>>>>>>>> /browse/OFBIZ-8045
>>>>>>>> Project: OFBiz
>>>>>>>> Issue Type: Sub-task
>>>>>>>> Components: accounting
>>>>>>>> Reporter: Tanmay Muley
>>>>>>>> Assignee: Michael Brohl
>>>>>>>> Priority: Minor
>>>>>>>> Fix For: Trunk
>>>>>>>>
>>>>>>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch,
>>>>>>>> OFBIZ-8045.patch
>>>>>>>>
>>>>>>>>
>>>>>>>> Change all form names to upper camel case for consistency.
>>>>>>>>
>>>>>>>>
>>>>>>> --
>>>>>>> This message was sent by Atlassian JIRA
>>>>>>> (v6.3.4#6332)
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>
>>>
>>
>
>
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name
Posted by Scott Gray <sc...@hotwaxsystems.com>.
A single commit is fine IMO if the changes are all focused on something
specific. The only style of commit I would object to are ones that
incorporate a non-trivial number of unrelated changes, otherwise whatever
works best for the committer is fine by me.
Regards
Scott
On 5 September 2016 at 21:26, Michael Brohl <mi...@ecomify.de>
wrote:
> Thanks for your suggestions, Akash and Jacques.
>
> To be clear, my question is only for these specific changes which I plan
> do review and commit.
>
> They are all of the same nature, easy to review and a single commit would
> avoid to write a lot of similar commit messages, references to different
> revisions in Jira etc. It would be simply more efficient.
>
> This should not be applied as a general rule I think, I generally prefer
> more granular commits for different changes.
>
> Other opinions?
>
> Regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 05.09.16 um 11:00 schrieb Jacques Le Roux:
>
> BTW, this was not exactly Michael's question (apart your 1st point). We
>> can have several sub-tasks but commit all of them in one shoot.
>>
>> Others opinions? Anyway I don't think we can have a global agreement (for
>> every Jiras) on this, because it really dependd on the content of the
>> subtasks patches.
>>
>> Jacques
>>
>>
>> Le 05/09/2016 à 10:36, Jacques Le Roux a écrit :
>>
>>> Makes sense Akash, thanks!
>>>
>>> Jacques
>>>
>>>
>>> Le 05/09/2016 à 07:39, Akash Jain a écrit :
>>>
>>>> I think both ways are fine but personally I like to do this kind of
>>>> changes
>>>> component wise because,
>>>> -- it's easy to review
>>>> -- more users and committers can involve
>>>> -- easy for beginners to contribute
>>>>
>>>> Thanks and Regards
>>>> --
>>>> Akash Jain
>>>>
>>>> On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux <
>>>> jacques.le.roux@les7arts.com> wrote:
>>>>
>>>> I wonder, it would be a bit easier to commit but the review could be
>>>>> harder, a moot point I'd say
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 04/09/2016 à 13:47, Michael Brohl a écrit :
>>>>>
>>>>> This might disappear in the many notifications so I'd like to asked the
>>>>>> below question also here in the dev list.
>>>>>> What do you think?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Michael Brohl
>>>>>> ecomify GmbH
>>>>>> www.ecomify.de
>>>>>>
>>>>>> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>>>>>>
>>>>>> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.
>>>>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>>>>> l&focusedCommentId=15462791#comment-15462791 ]
>>>>>>>
>>>>>>> Michael Brohl commented on OFBIZ-8045:
>>>>>>> --------------------------------------
>>>>>>>
>>>>>>> I think about doing these changes and all the other similar ones in
>>>>>>> one
>>>>>>> single commit and not issue by issue, what do others think about
>>>>>>> this?
>>>>>>>
>>>>>>> Accounting: Consistent form name
>>>>>>>
>>>>>>>> --------------------------------
>>>>>>>>
>>>>>>>> Key: OFBIZ-8045
>>>>>>>> URL: https://issues.apache.org/jira
>>>>>>>> /browse/OFBIZ-8045
>>>>>>>> Project: OFBiz
>>>>>>>> Issue Type: Sub-task
>>>>>>>> Components: accounting
>>>>>>>> Reporter: Tanmay Muley
>>>>>>>> Assignee: Michael Brohl
>>>>>>>> Priority: Minor
>>>>>>>> Fix For: Trunk
>>>>>>>>
>>>>>>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch,
>>>>>>>> OFBIZ-8045.patch
>>>>>>>>
>>>>>>>>
>>>>>>>> Change all form names to upper camel case for consistency.
>>>>>>>>
>>>>>>>>
>>>>>>> --
>>>>>>> This message was sent by Atlassian JIRA
>>>>>>> (v6.3.4#6332)
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>
>>>
>>
>
>
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name
Posted by Michael Brohl <mi...@ecomify.de>.
Thanks for your suggestions, Akash and Jacques.
To be clear, my question is only for these specific changes which I plan
do review and commit.
They are all of the same nature, easy to review and a single commit
would avoid to write a lot of similar commit messages, references to
different revisions in Jira etc. It would be simply more efficient.
This should not be applied as a general rule I think, I generally prefer
more granular commits for different changes.
Other opinions?
Regards,
Michael Brohl
ecomify GmbH
www.ecomify.de
Am 05.09.16 um 11:00 schrieb Jacques Le Roux:
> BTW, this was not exactly Michael's question (apart your 1st point).
> We can have several sub-tasks but commit all of them in one shoot.
>
> Others opinions? Anyway I don't think we can have a global agreement
> (for every Jiras) on this, because it really dependd on the content of
> the subtasks patches.
>
> Jacques
>
>
> Le 05/09/2016 à 10:36, Jacques Le Roux a écrit :
>> Makes sense Akash, thanks!
>>
>> Jacques
>>
>>
>> Le 05/09/2016 à 07:39, Akash Jain a écrit :
>>> I think both ways are fine but personally I like to do this kind of
>>> changes
>>> component wise because,
>>> -- it's easy to review
>>> -- more users and committers can involve
>>> -- easy for beginners to contribute
>>>
>>> Thanks and Regards
>>> --
>>> Akash Jain
>>>
>>> On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux <
>>> jacques.le.roux@les7arts.com> wrote:
>>>
>>>> I wonder, it would be a bit easier to commit but the review could be
>>>> harder, a moot point I'd say
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 04/09/2016 à 13:47, Michael Brohl a écrit :
>>>>
>>>>> This might disappear in the many notifications so I'd like to
>>>>> asked the
>>>>> below question also here in the dev list.
>>>>> What do you think?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Michael Brohl
>>>>> ecomify GmbH
>>>>> www.ecomify.de
>>>>>
>>>>> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>>>>>
>>>>>> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.
>>>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>>>> l&focusedCommentId=15462791#comment-15462791 ]
>>>>>>
>>>>>> Michael Brohl commented on OFBIZ-8045:
>>>>>> --------------------------------------
>>>>>>
>>>>>> I think about doing these changes and all the other similar ones
>>>>>> in one
>>>>>> single commit and not issue by issue, what do others think about
>>>>>> this?
>>>>>>
>>>>>> Accounting: Consistent form name
>>>>>>> --------------------------------
>>>>>>>
>>>>>>> Key: OFBIZ-8045
>>>>>>> URL:
>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-8045
>>>>>>> Project: OFBiz
>>>>>>> Issue Type: Sub-task
>>>>>>> Components: accounting
>>>>>>> Reporter: Tanmay Muley
>>>>>>> Assignee: Michael Brohl
>>>>>>> Priority: Minor
>>>>>>> Fix For: Trunk
>>>>>>>
>>>>>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch,
>>>>>>> OFBIZ-8045.patch
>>>>>>>
>>>>>>>
>>>>>>> Change all form names to upper camel case for consistency.
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> This message was sent by Atlassian JIRA
>>>>>> (v6.3.4#6332)
>>>>>>
>>>>>
>>>>>
>>
>>
>
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form
name
Posted by Jacques Le Roux <ja...@les7arts.com>.
BTW, this was not exactly Michael's question (apart your 1st point). We can have several sub-tasks but commit all of them in one shoot.
Others opinions? Anyway I don't think we can have a global agreement (for every Jiras) on this, because it really dependd on the content of the
subtasks patches.
Jacques
Le 05/09/2016 � 10:36, Jacques Le Roux a �crit :
> Makes sense Akash, thanks!
>
> Jacques
>
>
> Le 05/09/2016 � 07:39, Akash Jain a �crit :
>> I think both ways are fine but personally I like to do this kind of changes
>> component wise because,
>> -- it's easy to review
>> -- more users and committers can involve
>> -- easy for beginners to contribute
>>
>> Thanks and Regards
>> --
>> Akash Jain
>>
>> On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>>> I wonder, it would be a bit easier to commit but the review could be
>>> harder, a moot point I'd say
>>>
>>> Jacques
>>>
>>>
>>> Le 04/09/2016 � 13:47, Michael Brohl a �crit :
>>>
>>>> This might disappear in the many notifications so I'd like to asked the
>>>> below question also here in the dev list.
>>>> What do you think?
>>>>
>>>> Thanks,
>>>>
>>>> Michael Brohl
>>>> ecomify GmbH
>>>> www.ecomify.de
>>>>
>>>> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>>>>
>>>>> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.
>>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>>> l&focusedCommentId=15462791#comment-15462791 ]
>>>>>
>>>>> Michael Brohl commented on OFBIZ-8045:
>>>>> --------------------------------------
>>>>>
>>>>> I think about doing these changes and all the other similar ones in one
>>>>> single commit and not issue by issue, what do others think about this?
>>>>>
>>>>> Accounting: Consistent form name
>>>>>> --------------------------------
>>>>>>
>>>>>> Key: OFBIZ-8045
>>>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-8045
>>>>>> Project: OFBiz
>>>>>> Issue Type: Sub-task
>>>>>> Components: accounting
>>>>>> Reporter: Tanmay Muley
>>>>>> Assignee: Michael Brohl
>>>>>> Priority: Minor
>>>>>> Fix For: Trunk
>>>>>>
>>>>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch,
>>>>>> OFBIZ-8045.patch
>>>>>>
>>>>>>
>>>>>> Change all form names to upper camel case for consistency.
>>>>>>
>>>>>
>>>>> --
>>>>> This message was sent by Atlassian JIRA
>>>>> (v6.3.4#6332)
>>>>>
>>>>
>>>>
>
>
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form
name
Posted by Jacques Le Roux <ja...@les7arts.com>.
Makes sense Akash, thanks!
Jacques
Le 05/09/2016 � 07:39, Akash Jain a �crit :
> I think both ways are fine but personally I like to do this kind of changes
> component wise because,
> -- it's easy to review
> -- more users and committers can involve
> -- easy for beginners to contribute
>
> Thanks and Regards
> --
> Akash Jain
>
> On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> I wonder, it would be a bit easier to commit but the review could be
>> harder, a moot point I'd say
>>
>> Jacques
>>
>>
>> Le 04/09/2016 � 13:47, Michael Brohl a �crit :
>>
>>> This might disappear in the many notifications so I'd like to asked the
>>> below question also here in the dev list.
>>> What do you think?
>>>
>>> Thanks,
>>>
>>> Michael Brohl
>>> ecomify GmbH
>>> www.ecomify.de
>>>
>>> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>>>
>>>> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.
>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>> l&focusedCommentId=15462791#comment-15462791 ]
>>>>
>>>> Michael Brohl commented on OFBIZ-8045:
>>>> --------------------------------------
>>>>
>>>> I think about doing these changes and all the other similar ones in one
>>>> single commit and not issue by issue, what do others think about this?
>>>>
>>>> Accounting: Consistent form name
>>>>> --------------------------------
>>>>>
>>>>> Key: OFBIZ-8045
>>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-8045
>>>>> Project: OFBiz
>>>>> Issue Type: Sub-task
>>>>> Components: accounting
>>>>> Reporter: Tanmay Muley
>>>>> Assignee: Michael Brohl
>>>>> Priority: Minor
>>>>> Fix For: Trunk
>>>>>
>>>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch,
>>>>> OFBIZ-8045.patch
>>>>>
>>>>>
>>>>> Change all form names to upper camel case for consistency.
>>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.3.4#6332)
>>>>
>>>
>>>
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form name
Posted by Akash Jain <ak...@hotwaxsystems.com>.
I think both ways are fine but personally I like to do this kind of changes
component wise because,
-- it's easy to review
-- more users and committers can involve
-- easy for beginners to contribute
Thanks and Regards
--
Akash Jain
On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> I wonder, it would be a bit easier to commit but the review could be
> harder, a moot point I'd say
>
> Jacques
>
>
> Le 04/09/2016 à 13:47, Michael Brohl a écrit :
>
>> This might disappear in the many notifications so I'd like to asked the
>> below question also here in the dev list.
>> What do you think?
>>
>> Thanks,
>>
>> Michael Brohl
>> ecomify GmbH
>> www.ecomify.de
>>
>> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>>
>>> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.
>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>> l&focusedCommentId=15462791#comment-15462791 ]
>>>
>>> Michael Brohl commented on OFBIZ-8045:
>>> --------------------------------------
>>>
>>> I think about doing these changes and all the other similar ones in one
>>> single commit and not issue by issue, what do others think about this?
>>>
>>> Accounting: Consistent form name
>>>> --------------------------------
>>>>
>>>> Key: OFBIZ-8045
>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-8045
>>>> Project: OFBiz
>>>> Issue Type: Sub-task
>>>> Components: accounting
>>>> Reporter: Tanmay Muley
>>>> Assignee: Michael Brohl
>>>> Priority: Minor
>>>> Fix For: Trunk
>>>>
>>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch,
>>>> OFBIZ-8045.patch
>>>>
>>>>
>>>> Change all form names to upper camel case for consistency.
>>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.4#6332)
>>>
>>
>>
>>
>
Re: [jira] [Commented] (OFBIZ-8045) Accounting: Consistent form
name
Posted by Jacques Le Roux <ja...@les7arts.com>.
I wonder, it would be a bit easier to commit but the review could be harder, a moot point I'd say
Jacques
Le 04/09/2016 � 13:47, Michael Brohl a �crit :
> This might disappear in the many notifications so I'd like to asked the below question also here in the dev list.
> What do you think?
>
> Thanks,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA):
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15462791#comment-15462791
>> ]
>>
>> Michael Brohl commented on OFBIZ-8045:
>> --------------------------------------
>>
>> I think about doing these changes and all the other similar ones in one single commit and not issue by issue, what do others think about this?
>>
>>> Accounting: Consistent form name
>>> --------------------------------
>>>
>>> Key: OFBIZ-8045
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-8045
>>> Project: OFBiz
>>> Issue Type: Sub-task
>>> Components: accounting
>>> Reporter: Tanmay Muley
>>> Assignee: Michael Brohl
>>> Priority: Minor
>>> Fix For: Trunk
>>>
>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch, OFBIZ-8045.patch
>>>
>>>
>>> Change all form names to upper camel case for consistency.
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>
>