[GitHub] [incubator-mxnet] Zha0q1 edited a comment on issue #15069: [WIP] Profiler RFC: Introducing new APIs

[GitBox <gi...@apache.org>]

Zha0q1 edited a comment on issue #15069: [WIP] Profiler RFC: Introducing new APIs
URL: https://github.com/apache/incubator-mxnet/issues/15069#issuecomment-496782815
 
 
   > I understand the value of getting the dump output in a different format compared to tabular form. This can also be useful for doing post-processing on the dumped output as required by new profiler features like these: #14973 . Having said that, I think of `get_summary` as similar to `dumps` but outputting a different format. In this sense, we don't need to add a new API but just add support format to existing API. For example:
   > 
   > ```
   > def dumps(reset=False, format="table" or "json", sort_by=..)
   > ```
   
   My intension was to not change the existing APIs, but I can see your point. Do you think we need sorting for the tabular output though? @anirudh2290 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services