[jira] [Commented] (OAK-4390) DocumentStoreStatsIT.update fails when RDB's append mode is disabled

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295627#comment-15295627 ] 

Julian Reschke commented on OAK-4390:
-------------------------------------

The reason being that in this case a different code path is used, and that creates different kinds of statistics.

[~chetanm] - is there a particular reason why the stats are taken relatively low-level and not closer to the API call?

> DocumentStoreStatsIT.update fails when RDB's append mode is disabled
> --------------------------------------------------------------------
>
>                 Key: OAK-4390
>                 URL: https://issues.apache.org/jira/browse/OAK-4390
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: rdbmk
>    Affects Versions: 1.4.2, 1.5.2
>            Reporter: Julian Reschke
>
> When run with {{-Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.NOAPPEND=true}} (see OAK-4389):
> {noformat}
> update[RDBFixture: RDB-Postgres](org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT)  Time elapsed: 0.008 sec  <<< FAILURE!
> Wanted but not invoked:
> documentStoreStatsCollector.doneUpdate(
>     <any>,
>     nodes,
>     2
> );
> -> at org.apache.jackrabbit.oak.plugins.document.DocumentStoreStatsIT.update(DocumentStoreStatsIT.java:128)
> However, there were other interactions with this mock:
> documentStoreStatsCollector.doneCreate(
>     1747821,
>     nodes,
>     [update[RDBFixture: RDB-Postgres]],
>     true
> );
> -> at org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalCreate(RDBDocumentStore.java:1182)
> documentStoreStatsCollector.doneFindUncached(
>     845900,
>     nodes,
>     "update[RDBFixture: RDB-Postgres]-478ebbb3-cb70-409d-af13-f1b2c11c4103",
>     false,
>     false
> );
> -> at org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentUncached(RDBDocumentStore.java:1484)
> documentStoreStatsCollector.doneFindCached(
>     nodes,
>     "update[RDBFixture: RDB-Postgres]"
> );
> -> at org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.readDocumentCached(RDBDocumentStore.java:1093)
> documentStoreStatsCollector.doneFindAndModify(
>     1521593,
>     nodes,
>     "update[RDBFixture: RDB-Postgres]",
>     false,
>     true,
>     -1
> );
> -> at org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalUpdate(RDBDocumentStore.java:1299)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)