[GitHub] [spark] amaliujia commented on a diff in pull request #37994: [SPARK-40454][CONNECT] Initial DSL framework for protobuf testing

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #37994:
URL: https://github.com/apache/spark/pull/37994#discussion_r980308023


##########
connect/src/main/scala/org/apache/spark/sql/connect/package.scala:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql
+
+import org.apache.spark.connect.proto
+

Review Comment:
   I changed to match what catalyst's DSL is doing. I also added  class comment.
   
   However when I try to document the usage guide, I found the import that works in test code which does not work for spark-shell
   
   ```
   
   scala> import org.apache.spark.sql.connect.plans.DslLogicalPlan
   <console>:23: error: object connect is not a member of package org.apache.spark.sql
          import org.apache.spark.sql.connect.plans.DslLogicalPlan
   ```
   
    I am thinking this is a part of cleanup work that we need to do. Can I create a follow up JIRA to fix this then go back to document the DSL usage next time?      
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org