You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/28 20:34:37 UTC

[GitHub] [maven-jlink-plugin] aalmiray commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

aalmiray commented on a change in pull request #9:
URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r513742812



##########
File path: pom.xml
##########
@@ -132,6 +131,16 @@
   <build>
     <pluginManagement>
       <plugins>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-compiler-plugin</artifactId>
+          <version>3.8.1</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-plugin-plugin</artifactId>
+          <version>3.6.0</version>

Review comment:
       Wouldn't it make more sense to update `<mavenVersion>3.0</mavenVersion>` to `3.6.3`? Other dependencies in the POM are tied to that property.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org