You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2024/11/25 13:17:42 UTC
[PR] IGNITE-23767 Use shared threadpools in RocksDbFlusher for TxStateRocksDbSharedStorage [ignite-3]
tkalkirill opened a new pull request, #4788:
URL: https://github.com/apache/ignite-3/pull/4788
https://issues.apache.org/jira/browse/IGNITE-23767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23767 Use shared threadpools in RocksDbFlusher for TxStateRocksDbSharedStorage [ignite-3]
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #4788:
URL: https://github.com/apache/ignite-3/pull/4788#discussion_r1856635994
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -980,7 +980,7 @@ public class IgniteImpl implements Ignite {
StorageUpdateConfiguration storageUpdateConfiguration = clusterConfigRegistry
.getConfiguration(StorageUpdateExtensionConfiguration.KEY).storageUpdate();
- distributedTblMgr = new TableManager(
+ distributedTblMgr = new TableManager(
Review Comment:
```suggestion
distributedTblMgr = new TableManager(
```
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java:
##########
@@ -262,8 +261,12 @@ public class TableManagerTest extends IgniteAbstractTest {
/** Catalog manager. */
private CatalogManager catalogManager;
+ @InjectExecutorService(threadCount = 5, allowedOperations = {STORAGE_READ, STORAGE_WRITE})
Review Comment:
Let's add thread name in the future as well. Not now, of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23767 Use shared threadpools in RocksDbFlusher for TxStateRocksDbSharedStorage [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #4788:
URL: https://github.com/apache/ignite-3/pull/4788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org