[GitHub] [arrow-datafusion] aprimadi commented on a diff in pull request #6260: Add more documentation to SortPreservingMergeStream

["aprimadi (via GitHub)" <gi...@apache.org>]

aprimadi commented on code in PR #6260:
URL: https://github.com/apache/arrow-datafusion/pull/6260#discussion_r1188097449


##########
datafusion/core/src/physical_plan/sorts/sort_preserving_merge.rs:
##########
@@ -506,6 +506,71 @@ mod tests {
         assert_batches_eq!(exp, collected.as_slice());
     }
 
+    #[tokio::test]
+    async fn test_merge_five_partitions() {

Review Comment:
   Ah yes, I added that test just to convince myself that the implementation of loser tree works.
   
   Now I'm pretty sure it works, perhaps we can remove it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org