You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org> on 2009/07/14 17:06:14 UTC
[jira] Created: (QPID-1987) Patch for 0.10 C# API
Patch for 0.10 C# API
---------------------
Key: QPID-1987
URL: https://issues.apache.org/jira/browse/QPID-1987
Project: Qpid
Issue Type: Improvement
Components: Dot Net Client
Reporter: Julien Lavigne du Cadet
Priority: Critical
Please find attached a patch correcting the following issues :
- Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
- Fixes public API to match standard .NET conventions (QPID-500)
- Fixes code generation to match standard .NET conventions
- Fixes ToString() methods that don't override base classes
- Fixes blocking TearingDown in unit tests
- Use a .config file for tests/samples
- Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
- Make the console solution compiling under Visual Studio 2008
I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1987) Patch for 0.10 C# API
Posted by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Lavigne du Cadet updated QPID-1987:
------------------------------------------
Attachment: qpid-dotnet - build.patch
Slight modification to the previous patch
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Assignee: Ted Ross
> Priority: Critical
> Attachments: qpid-.net.patch, qpid-dotnet - build.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-1987) Patch for 0.10 C# API
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner reassigned QPID-1987:
-----------------------------------
Assignee: Aidan Skinner (was: Ted Ross)
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Assignee: Aidan Skinner
> Priority: Critical
> Attachments: qpid-.net.patch, qpid-dotnet - build.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-1987) Patch for 0.10 C# API
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner resolved QPID-1987.
---------------------------------
Resolution: Fixed
Patches applied.
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Affects Versions: 0.5, 0.6
> Reporter: Julien Lavigne du Cadet
> Assignee: Aidan Skinner
> Priority: Critical
> Fix For: 0.6
>
> Attachments: qpid-.net.patch, qpid-dotnet - build.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1987) Patch for 0.10 C# API
Posted by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Lavigne du Cadet updated QPID-1987:
------------------------------------------
Attachment: qpid-.net.patch
The patch
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Priority: Critical
> Attachments: qpid-.net.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1987) Patch for 0.10 C# API
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner updated QPID-1987:
--------------------------------
Affects Version/s: 0.6
0.5
Fix Version/s: 0.6
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Affects Versions: 0.5, 0.6
> Reporter: Julien Lavigne du Cadet
> Assignee: Aidan Skinner
> Priority: Critical
> Fix For: 0.6
>
> Attachments: qpid-.net.patch, qpid-dotnet - build.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1987) Patch for 0.10 C# API
Posted by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Lavigne du Cadet updated QPID-1987:
------------------------------------------
Attachment: (was: qpid-dotnet - build.patch)
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Assignee: Ted Ross
> Priority: Critical
> Attachments: qpid-.net.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1987) Patch for 0.10 C# API
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732202#action_12732202 ]
Ted Ross commented on QPID-1987:
--------------------------------
This patch does not apply on Linux. Even if I unix2dos all of the affected files before applying, it still fails with a very large number of errors (HUNK #x FAILED at y.).
I can get the patch to apply on Windows but I have been unable to build under Visual Studio 2008. The documentation says "build normally under VS2005" but gives no further details. Is VS2008 significantly different from VS2005? Is there something else I'm missing?
-Ted
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Assignee: Ted Ross
> Priority: Critical
> Attachments: qpid-.net.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1987) Patch for 0.10 C# API
Posted by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732377#action_12732377 ]
Julien Lavigne du Cadet commented on QPID-1987:
-----------------------------------------------
As long as no .Net 3/.Net 3.5 features are used it should be trivial to either compile under VS 2008 or VS 2005. Please note that you would have to recreate a solution file for VS 2005 as the one in the sources is for 2008 only (solutions files are not compatible between 2005 and 2008).
However, I've been working on the API with VS 2008 and I never had any specific problems so far. What kind of errors are you seeing?
It's probably a silly question bug have you regenerated the files from the client-010/gentool directory? This is a required step as I changed the the .py and .tpl files to accomodate the usual .Net convention regarding method naming (in pascal case and not in camel case)
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Assignee: Ted Ross
> Priority: Critical
> Attachments: qpid-.net.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-1987) Patch for 0.10 C# API
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Ross reassigned QPID-1987:
------------------------------
Assignee: Ted Ross
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Assignee: Ted Ross
> Priority: Critical
> Attachments: qpid-.net.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1987) Patch for 0.10 C# API
Posted by "Julien Lavigne du Cadet (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Lavigne du Cadet updated QPID-1987:
------------------------------------------
Attachment: qpid-dotnet - build.patch
Here is a patch to clarify the generation process.
It contains an update to the build.xml to point to the correct path for jython and some new instructions to build the api.
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Assignee: Ted Ross
> Priority: Critical
> Attachments: qpid-.net.patch, qpid-dotnet - build.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1987) Patch for 0.10 C# API
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784576#action_12784576 ]
Aidan Skinner commented on QPID-1987:
-------------------------------------
UberFAIL that we haven't gotten this in. Patch looks ok, but i don't have a windows install handy just now. Will try to make sure this goes into 0.6.
> Patch for 0.10 C# API
> ---------------------
>
> Key: QPID-1987
> URL: https://issues.apache.org/jira/browse/QPID-1987
> Project: Qpid
> Issue Type: Improvement
> Components: Dot Net Client
> Reporter: Julien Lavigne du Cadet
> Assignee: Aidan Skinner
> Priority: Critical
> Attachments: qpid-.net.patch, qpid-dotnet - build.patch
>
>
> Please find attached a patch correcting the following issues :
> - Fixes UUID.randomUUID() which is not thread-safe (QPID-1972)
> - Fixes public API to match standard .NET conventions (QPID-500)
> - Fixes code generation to match standard .NET conventions
> - Fixes ToString() methods that don't override base classes
> - Fixes blocking TearingDown in unit tests
> - Use a .config file for tests/samples
> - Adds interface to Invoker, Session and ClientSession to allow easy mocking of the API
> - Make the console solution compiling under Visual Studio 2008
> I'm more than happy to discuss any of this by email or through JIRA. Please let me know if there's no plan (or nobody available) to evaluate this patch for inclusion. If that is the case, I will consider forking the API to continue fixing the API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org