[GitHub] rabbah commented on a change in pull request #2893: WIP Support retrieving status and configuration of feed triggers in CLI

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #2893: WIP Support retrieving status and configuration of feed triggers in CLI
URL: https://github.com/apache/incubator-openwhisk/pull/2893#discussion_r149775093
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala
 ##########
 @@ -1125,6 +1124,73 @@ class WskBasicUsageTests extends TestHelpers with WskTestHelpers {
     }
   }
 
+  it should "invoke a feed action with the correct lifecyle event when creating a feed trigger" in withAssetCleaner(
 
 Review comment:
   the asset cleaner is a convenience - use it where it make sense.
   your code looks good to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services