You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/03/02 13:44:58 UTC
Re: Review Request 69955: Added SLRP unit tests for destroying
unpublished persistent volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69955/#review213349
-----------------------------------------------------------
Bad review!
Reviews applied: [69955, 69954, 69403, 69905, 69904, 69898, 69897, 69896, 69895, 69894, 69893, 69892, 69866, 69858]
Error:
2019-03-02 13:44:57 URL:https://reviews.apache.org/r/69954/diff/raw/ [7553/7553] -> "69954.patch" [1]
error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:361
error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply
- Mesos Reviewbot
On Feb. 11, 2019, 9:28 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69955/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2019, 9:28 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9565
> https://issues.apache.org/jira/browse/MESOS-9565
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds 3 unit tests: `DestroyUnpublishedPersistentVolume`,
> `DestroyUnpublishedPersistentVolumeWithRecovery`, and
> `DestroyUnpublishedPersistentVolumeWithReboot` to test that the SLRP is
> resilient to misbehaved CSI plugins that fail to publish volumes.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69955/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>