You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2021/08/18 08:57:32 UTC
[shardingsphere] branch master updated: Refactor code (#11878)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new ed2dad3 Refactor code (#11878)
ed2dad3 is described below
commit ed2dad3a2532c4a76eedb21d408365a30f2eaa50
Author: Dachuan J <46...@users.noreply.github.com>
AuthorDate: Wed Aug 18 16:57:00 2021 +0800
Refactor code (#11878)
---
.../metrics/prometheus/collector/MetaDataInfoCollector.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/MetaDataInfoCollector.java b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/MetaDataInfoCollector.java
index 961d5c7..db5fe25 100644
--- a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/MetaDataInfoCollector.java
+++ b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/collector/MetaDataInfoCollector.java
@@ -66,19 +66,19 @@ public final class MetaDataInfoCollector extends Collector {
private void collectProxy(final GaugeMetricFamily metricFamily) {
MetaDataContexts metaDataContexts = ProxyContext.getInstance().getContextManager().getMetaDataContexts();
metricFamily.addMetric(Collections.singletonList(LOGIC_DB_COUNT), metaDataContexts.getMetaDataMap().size());
- Set<String> databaseMap = new HashSet<>();
+ Set<String> databaseSet = new HashSet<>();
metaDataContexts.getMetaDataMap().values().forEach(each -> each.getResource().getDataSources().values()
- .forEach(dataSource -> MetaDataInfoCollector.this.countDatabase(databaseMap, dataSource)));
- metricFamily.addMetric(Collections.singletonList(ACTUAL_DB_COUNT), databaseMap.size());
+ .forEach(dataSource -> MetaDataInfoCollector.this.countDatabase(databaseSet, dataSource)));
+ metricFamily.addMetric(Collections.singletonList(ACTUAL_DB_COUNT), databaseSet.size());
}
- private void countDatabase(final Set<String> databaseMap, final DataSource dataSource) {
+ private void countDatabase(final Set<String> databaseSet, final DataSource dataSource) {
if (dataSource instanceof HikariDataSource) {
String jdbcUrl = ((HikariDataSource) dataSource).getJdbcUrl();
try {
URI uri = new URI(jdbcUrl.substring(5));
if (null != uri.getPath()) {
- databaseMap.add(uri.getPath());
+ databaseSet.add(uri.getPath());
}
} catch (URISyntaxException | NullPointerException e) {
log.info("Unsupported jdbc url by URI: {}", jdbcUrl);