You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Sander Striker <st...@apache.org> on 2003/02/12 11:16:32 UTC
[PATCH] Allow modules to load if they were compiled with AP_DEBUG (--enable-maintainer-mode) although the core was not.
This patch might be incomplete in that I'm not completely sure how to
handle the exports. Basically ap_[gs]et_module_config should always
be in exports.c.
Secondly, while looking at util_debug.c, I see that we have more
functions we conditionally define. We may want to define those all
the time aswell.
Sander
Index: server/util_debug.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/util_debug.c,v
retrieving revision 1.9
diff -u -r1.9 util_debug.c
--- server/util_debug.c 3 Feb 2003 17:53:20 -0000 1.9
+++ server/util_debug.c 12 Feb 2003 10:10:19 -0000
@@ -94,6 +94,13 @@
return strstr(s,c);
}
+#endif /* AP_DEBUG */
+
+#if defined(ap_get_module_config)
+#undef ap_get_module_config
+AP_DECLARE(void *) ap_get_module_config(const ap_conf_vector_t *cv,
+ const module *m);
+#endif
AP_DECLARE(void *) ap_get_module_config(const ap_conf_vector_t *cv,
const module *m)
@@ -110,11 +117,14 @@
* @param val The module-specific data to set
* @deffunc void ap_set_module_config(ap_conf_vector_t *cv, const module *m, void *val)
*/
+#if defined(ap_set_module_config)
+#undef ap_set_module_config
+AP_DECLARE(void) ap_set_module_config(ap_conf_vector_t *cv, const module *m,
+ void *val);
+#endif
+
AP_DECLARE(void) ap_set_module_config(ap_conf_vector_t *cv, const module *m,
void *val)
{
((void **)cv)[m->module_index] = val;
}
-
-
-#endif /* AP_DEBUG */
Re: [PATCH] Allow modules to load if they were compiled with AP_DEBUG
(--enable-maintainer-mode) although the core was not.
Posted by Jeff Trawick <tr...@attglobal.net>.
Sander Striker wrote:
> This patch might be incomplete in that I'm not completely sure how to
> handle the exports. Basically ap_[gs]et_module_config should always
> be in exports.c.
>
> Secondly, while looking at util_debug.c, I see that we have more
> functions we conditionally define. We may want to define those all
> the time aswell.
definitely; I still have teeth marks from this one
+1 (concept)