You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@commons.apache.org by Greg Stein <gs...@lyra.org> on 2003/09/17 15:15:30 UTC
Re: SVN commit mail subject
On Wed, Sep 17, 2003 at 02:55:23PM +0200, Sander Striker wrote:
> > From: Rodent of Unusual Size [mailto:Ken.Coar@Golux.Com]
> > Sent: Wednesday, September 17, 2003 2:50 PM
>
> > is it possible to have svn omit the revision number from the subject
> > line?
>
> Possible, yes. Recommended, no. When you've used svn for a
> while you'll come to apreciate the rev number (in the subject
> line aswell)... :)
Agreed. You'll find the revision number is very handy, which means that
you'll really want to have it available. In many contexts, you might say
"rev 473 broke FOO" or "ah. that was fixed in rev 1340" or "eesh. we need
to revert rev 67."
You'll find the Subversion issue tracker littered with closed issues to
the tune of "fixed in rev 6310" or somesuch.
> > all these commits are showing up as unique threads rather
> > than a single thread with multiple messages..
>
> That's because these are all seperate commits, and thus all
> seperate (starts of) threads. I can't imagine the cvs commit
> mails are any different.
Right. Even if the rev number were removed, there is still the matter of
the directories. For both SVN and CVS commit emails, those will serve to
create different subjects and, thus, different threads.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: SVN commit mail subject
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
B. W. Fitzpatrick wrote:
>
> Well, I guess this comes down to a battle of who prefers what... I for
> one much prefer the status quo. Having commit messages threaded by
> revision number is great when you're discussing a particular commit.
> This is my preference. :-)
>
>> having the rev number in the subject line is an advantage when you
>> look for changes by revision. it is a *disadvantage* when you're
>> looking for things by module or topic.
>
> Your subjective opinion...
correct. i will make two more points and then shut up. the first
is that this threading model may be standard on non-asf projects
like svn, but it is a deviation from all of the other commit notice
scenarios in apache-land. second, i rather object to the people
familiar with subversion more-or-less forcing their opinion on
the community because a) that's what *they're* used to, b) it's what
*they* prefer, and c) *they're* the only ones who know how to change
it. :-)
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millennium hand and shrimp!"
Re: SVN commit mail subject
Posted by "B. W. Fitzpatrick" <fi...@red-bean.com>.
Rodent of Unusual Size <Ke...@Golux.Com> writes:
> Greg Stein wrote:
> > On Wed, Sep 17, 2003 at 02:55:23PM +0200, Sander Striker wrote:
> >>
> >> Possible, yes. Recommended, no. When you've used svn for a
> >> while you'll come to apreciate the rev number (in the subject
> >> line aswell)... :)
> >
> > Agreed. You'll find the revision number is very handy, which means that
> > you'll really want to have it available. In many contexts, you might say
> > "rev 473 broke FOO" or "ah. that was fixed in rev 1340" or "eesh. we need
> > to revert rev 67."
> >
> > You'll find the Subversion issue tracker littered with closed issues to
> > the tune of "fixed in rev 6310" or somesuch.
>
> fine and dandy. however, i personally would prefer to see changes
> to a particular file to be all in the same thread, if that's the only
> file affected by a commit. i prefer to *not* have to scan all over
> my mail to collect them into one place when i want to review them
> sequentially.
Well, I guess this comes down to a battle of who prefers what... I for
one much prefer the status quo. Having commit messages threaded by
revision number is great when you're discussing a particular commit.
This is my preference. :-)
> having the rev number in the subject line is an advantage when you
> look for changes by revision. it is a *disadvantage* when you're
> looking for things by module or topic.
Your subjective opinion...
> so put the rev number into the body of the message, but please remove
> it from the subject line.
-0.5
-Fitz
--
Brian W. Fitzpatrick <fi...@red-bean.com> http://www.red-bean.com/fitz/
Re: SVN commit mail subject
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Wednesday, September 17, 2003 9:48 AM -0400 Rodent of Unusual Size
<Ke...@Golux.Com> wrote:
> so put the rev number into the body of the message, but please remove
> it from the subject line.
I find that the subject line on our CVS commits don't contain useful
information based on files alone as it only usually lists the files from the
last directory that was modified. So, if you only sort by the subject and
multiple directories were changed in a commit, the subject is not accurate.
At least the revision number helps to make it accurate. Subversion takes a
view that the entire repository is grouped together (or at least a set of
directories given our layout and config here), while CVS treats individual
files separately. So, the revision number maps well to Subversion as when it
sends a commit email it is saying, 'the repository changed to revision XXX.'
The fact that a bunch of files or directories changed is irrelevant in
Subversion.
So, count me -0 to removing the rev number from the subject line. -- justin
Re: SVN commit mail subject
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Greg Stein wrote:
> On Wed, Sep 17, 2003 at 02:55:23PM +0200, Sander Striker wrote:
>>
>> Possible, yes. Recommended, no. When you've used svn for a
>> while you'll come to apreciate the rev number (in the subject
>> line aswell)... :)
>
> Agreed. You'll find the revision number is very handy, which means that
> you'll really want to have it available. In many contexts, you might say
> "rev 473 broke FOO" or "ah. that was fixed in rev 1340" or "eesh. we need
> to revert rev 67."
>
> You'll find the Subversion issue tracker littered with closed issues to
> the tune of "fixed in rev 6310" or somesuch.
fine and dandy. however, i personally would prefer to see changes
to a particular file to be all in the same thread, if that's the only
file affected by a commit. i prefer to *not* have to scan all over
my mail to collect them into one place when i want to review them
sequentially.
having the rev number in the subject line is an advantage when you
look for changes by revision. it is a *disadvantage* when you're
looking for things by module or topic.
so put the rev number into the body of the message, but please remove
it from the subject line.
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millennium hand and shrimp!"