You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/27 16:04:49 UTC

[GitHub] [accumulo] jmark99 opened a new pull request #2039: Add bulk import option to ignore empty dirs

jmark99 opened a new pull request #2039:
URL: https://github.com/apache/accumulo/pull/2039


   Update the new bulk import operations to allow empty source directories to be ignored rather than throwing an exception. There is now a '-i' option that will log an info message indicating that the source directory was empty and no files were imported rather than throwing an IllegalArgumentException.
   
   This will support the use case of users who want to write idempotent bulk import code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] keith-turner commented on pull request #2039: Add bulk import option to ignore empty dirs

Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #2039:
URL: https://github.com/apache/accumulo/pull/2039#issuecomment-828562237


   The ImportOptions interface may be a good place to put it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] keith-turner edited a comment on pull request #2039: Add bulk import option to ignore empty dirs

Posted by GitBox <gi...@apache.org>.
keith-turner edited a comment on pull request #2039:
URL: https://github.com/apache/accumulo/pull/2039#issuecomment-828562237


   The ImportOptions interface may be a good place to put the new `ignoreEmptyDir()` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] jmark99 merged pull request #2039: Add bulk import option to ignore empty dirs

Posted by GitBox <gi...@apache.org>.
jmark99 merged pull request #2039:
URL: https://github.com/apache/accumulo/pull/2039


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] milleruntime commented on pull request #2039: Add bulk import option to ignore empty dirs

Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2039:
URL: https://github.com/apache/accumulo/pull/2039#issuecomment-828460235


   @jmark99 I think it might be better to add a method to the fluent API here: https://github.com/apache/accumulo/blob/5c365f984b13dec105ecb654cea486a06443d967/core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java#L731
   Perhaps a method called `ignoreEmptyDir()`. This will allow it to be an optional method and won't require a entry point method on `TableOperations`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] jmark99 commented on pull request #2039: Add bulk import option to ignore empty dirs

Posted by GitBox <gi...@apache.org>.
jmark99 commented on pull request #2039:
URL: https://github.com/apache/accumulo/pull/2039#issuecomment-828577087


   I will look into updating to take advantage of the fluent api.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] jmark99 commented on pull request #2039: Add bulk import option to ignore empty dirs

Posted by GitBox <gi...@apache.org>.
jmark99 commented on pull request #2039:
URL: https://github.com/apache/accumulo/pull/2039#issuecomment-828725244


   The update has been submitted as PR #2045 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org