[GitHub] trafodion pull request #1384: [TRAFODION-2879] Core dump ...plus four more f...

[zellerh <gi...@git.apache.org>]

GitHub user zellerh opened a pull request:

    https://github.com/apache/trafodion/pull/1384

    [TRAFODION-2879] Core dump ...plus four more fixes, see below

    This is a PR for four fixes, submitted as separate commits. I would recommend reviewing each commit separately, as the fixes are not related.
    
    Summary (also in the commit text for each fix):
    
    **[TRAFODION-2879] Core dump due to reference to deallocated memory for EstLogProp object**
    
    In the optimizer, we often use a define to refer to an "empty input
    logical properties" object. The problem was that this object was
    allocated on the statement heap but it was owned by the CmpContext
    object, which lives longer than the statement heap. During debugging,
    we have seen cases where this led to references of deleted memory.
    
    The fix is to move the empty logical properties to the CmpStatement
    object.
    
    Files: arkcmp/*
           RelExpr.h
    
    **[TRAFODION-2896] Internal error in stored procedures when a warning is generated in SQL**
    
    This problem was seen by Any on a large cluster and Selva found this issue
    during debugging. At this point we don't have an easy testcase to reproduce,
    but we agree that the code change is something we should do.
    
    udrserv/*
    
    **[TRAFODION-2897] Invalid name in MySQL log file when using install_local_hadoop**
    
    Bug reported on the dev list.
    
    install_local_hadoop
    
    
    **Other changes:**
    
    - Fixes in the OSIM tool related to external Hive tables. Issue an unregister
      command before creating a new Hive table in OSIM simulation mode.
      Also get the REGISTER commands from the OSIM files and send them to
      Trafodion, not to Hive, as before. Finally, make some minor changes
      to showddl (avoid extra commas, fix comments that showed REGISTER
      as a Hive command).
    
    CmpDescribe.cpp
    OptimizerSimulator.cpp
    
    - Cosmetic changes to JDBC TMUDF
    
    JDBCUDR.java


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zellerh/trafodion bug/R23

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1384
    
----
commit bb4edd48c909e889297ec0b0940d9d60745fd86c
Author: Hans Zeller <hz...@...>
Date:   2018-01-09T22:07:09Z

    [TRAFODION-2897] Invalid name in MySQL log file when using install_local_hadoop
    
    Bug reported on the dev list. MySQL does not understand shell syntax.

commit 90f0b665d54f6b04486e290afd118335167b1d18
Author: Hans Zeller <hz...@...>
Date:   2018-01-09T22:09:29Z

    [TRAFODION-2879] Core dump due to reference to deallocated memory for EstLogProp object
    
    In the optimizer, we often use a define to refer to an "empty input
    logical properties" object. The problem was that this object was
    allocated on the statement heap but it was owned by the CmpContext
    object, which lives longer than the statement heap. During debugging,
    we have seen cases where this led to references of deleted memory.
    
    The fix is to move the empty logical properties to the CmpStatement
    object.

commit 4d521af7799983c44f93e9ed46ed48c8871f7993
Author: Hans Zeller <hz...@...>
Date:   2018-01-09T22:10:33Z

    [TRAFODION-2896] Internal error in stored procedures when a warning is generated in SQL
    
    This problem was seen by Any on a large cluster and Selva found this issue
    during debugging. At this point we don't have an easy testcase to reproduce,
    but we agree that the code change is something we should do.

commit 40b1773401ac7bb323114f3cf180ccbfec1e8caa
Author: Hans Zeller <hz...@...>
Date:   2018-01-09T22:11:37Z

    OSIM changes and comment fix for JDBCUDR
    
    Two small changes w/o JIRA.
    
    Fixes in the OSIM tool related to external Hive tables. Issue an
    unregister command before creating a new Hive table in OSIM simulation
    mode.  Also get the REGISTER commands from the OSIM files and send
    them to Trafodion, not to Hive, as before. Finally, make some minor
    changes to showddl (avoid extra commas, fix comments that showed
    REGISTER as a Hive command).
    
    Cosmetic changes in the JDBC UDR (fix sandbox location in comment and
    use a utility method to get to the sandbox location instead of
    hard-coding it.).

----


---

[GitHub] trafodion pull request #1384: [TRAFODION-2879] Core dump ...plus four more f...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/trafodion/pull/1384


---