You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/02/19 12:05:45 UTC

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5336: minor: remove useless `.get()`

jackwener commented on code in PR #5336:
URL: https://github.com/apache/arrow-datafusion/pull/5336#discussion_r1111223465


##########
datafusion/optimizer/src/propagate_empty_relation.rs:
##########
@@ -149,14 +149,11 @@ fn binary_plan_children_is_empty(plan: &LogicalPlan) -> Result<(bool, bool)> {
     // all binary-plan need to deal with separately.
     match inputs.len() {
         2 => {
-            let left = inputs.get(0).unwrap();
-            let right = inputs.get(1).unwrap();
-
-            let left_empty = match left {
+            let left_empty = match inputs[0] {

Review Comment:
   thanks @Dandandan 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org