You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "aleitner (via GitHub)" <gi...@apache.org> on 2023/03/07 18:34:16 UTC
[GitHub] [guacamole-client] aleitner opened a new pull request, #806: GUACAMOLE-1740: Prevent collisions of clipboard inactive and active classes with other classes of the same name.
aleitner opened a new pull request, #806:
URL: https://github.com/apache/guacamole-client/pull/806
This pull request corrects the new CSS rules for the guacamole clipboard settings such that they affect strictly what they are intended to affect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper merged pull request #806: GUACAMOLE-1740: Prevent collisions of clipboard inactive and active classes with other classes of the same name.
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper merged PR #806:
URL: https://github.com/apache/guacamole-client/pull/806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] aleitner commented on a diff in pull request #806: GUACAMOLE-1740: Prevent collisions of clipboard inactive and active classes with other classes of the same name.
Posted by "aleitner (via GitHub)" <gi...@apache.org>.
aleitner commented on code in PR #806:
URL: https://github.com/apache/guacamole-client/pull/806#discussion_r1128436153
##########
guacamole/src/main/frontend/src/app/clipboard/templates/guacClipboard.html:
##########
@@ -1,4 +1,4 @@
-<div>
+<div id="clipboard-settings">
Review Comment:
Whoops. I got hyper focused on editing the clipboard directive and didn't check the client's id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #806: GUACAMOLE-1740: Prevent collisions of clipboard inactive and active classes with other classes of the same name.
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #806:
URL: https://github.com/apache/guacamole-client/pull/806#discussion_r1128419827
##########
guacamole/src/main/frontend/src/app/clipboard/templates/guacClipboard.html:
##########
@@ -1,4 +1,4 @@
-<div>
+<div id="clipboard-settings">
Review Comment:
The CSS rules added to `clipboard.css` look correct, however this duplicates the ID already present within the menu:
https://github.com/apache/guacamole-client/blob/a25fa1c98235c96c1b0d84904434d2d3ba00e7e5/guacamole/src/main/frontend/src/app/client/templates/client.html#L103-L110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org