You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/02/15 21:45:51 UTC
[GitHub] [logging-log4j2] marcushoja opened a new pull request #755: trim MaxBackupIndex if last char is blank
marcushoja opened a new pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755
using log4j1.2-api-2.x bridge with log4j.properties a blank after MaxBackupIndex=<value> stops creating the appender and logging is disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy merged pull request #755: trim MaxBackupIndex if last char is blank
Posted by GitBox <gi...@apache.org>.
vy merged pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #755: trim MaxBackupIndex if last char is blank
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1041787442
@garydgregory I have indeed addressed this everywhere in `DefaultRolloverStrategy`. For practicing this throughout the entire code base, be my guest. :wink:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #755: trim MaxBackupIndex if last char is blank
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1041405005
Just a second... would it not be better to look for all call sites and refactor this kind of convertion into an internal utility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #755: trim MaxBackupIndex if last char is blank
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1042927077
@ppkarwasz Good point. I have tried to see if it is something quick to fix. I have started with `min`, `max`, and `compressionLevel` in `DefaultRolloverStrategy`. Then it spread to `RollingRandomAccessFileAppender`. And then to `DirectWriteRolloverStrategy`. Hence, it is not a quick fix. I will return my back to my own TODO list. Though be my guest to submit a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] marcushoja commented on pull request #755: trim MaxBackupIndex if last char is blank
Posted by GitBox <gi...@apache.org>.
marcushoja commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1040828316
an invisible NumberFormatException is thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on pull request #755: trim MaxBackupIndex if last char is blank
Posted by GitBox <gi...@apache.org>.
ppkarwasz commented on pull request #755:
URL: https://github.com/apache/logging-log4j2/pull/755#issuecomment-1042361172
@vy: shouldn't `max` be of type `Integer`, so that the injection framework takes care of the conversion?
This would break the API, so can probably only be done in the `master` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org