You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/30 14:34:57 UTC

[GitHub] [bookkeeper] Shoothzj commented on a diff in pull request #3260: Optimize write cache: supports configuring multiple caches

Shoothzj commented on code in PR #3260:
URL: https://github.com/apache/bookkeeper/pull/3260#discussion_r911104660


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java:
##########
@@ -85,6 +91,15 @@ public class DbLedgerStorage implements LedgerStorage {
 
     private static final long DEFAULT_WRITE_CACHE_MAX_SIZE_MB = (long) (0.25 * PlatformDependent.maxDirectMemory())
             / MB;
+
+    private static final long DEFAULT_COMMON_WRITE_CACHE_MAX_SIZE_MB =
+            (long) (0.25 * PlatformDependent.maxDirectMemory()) / MB;

Review Comment:
   ```suggestion
               (long) (0.25 * PlatformDependent.estimateMaxDirectMemory()) / MB;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org