You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/03/05 02:48:30 UTC
[GitHub] flink pull request #5632: [FLINK-8843][REST] Decouple bind REST address from...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5632
[FLINK-8843][REST] Decouple bind REST address from advertised address
## What is the purpose of the change
*This pull request decouples bind REST address from advertised address*
## Brief change log
- *Change the default value from dns `localhost` to `0.0.0.0`*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8843
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5632
----
commit 1f31f4cbff82df421fc71fc41198a82ad5f50f6f
Author: vinoyang <vi...@...>
Date: 2018-03-05T02:46:40Z
[FLINK-8843][REST] Decouple bind REST address from advertised address
----
---
[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5632
I'll verify the changes @yanghua
---
[GitHub] flink pull request #5632: [FLINK-8843][REST] Decouple bind REST address from...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5632#discussion_r175072436
--- Diff: flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java ---
@@ -33,7 +33,7 @@
*/
public static final ConfigOption<String> REST_ADDRESS =
key("rest.address")
- .defaultValue("localhost")
+ .defaultValue("0.0.0.0")
--- End diff --
It's not enough to set the default value to `0.0.0.0`. The rest client uses the value under this config key to connect. I am taking over this ticket now. #5707
---
[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5632
hi @tillrohrmann I think you should review this PR and add it to 1.5 version as a hotfix. Because I just download the release-1.5 branch. And install it as standalone-session mode. But the general config in `flink-conf.yaml` can not let me access the web frontend with the JM server's remote IP(I access from remote node's browser), and I run command `netstat -anp | grep 8081` shows :
```
tcp 0 0 127.0.0.1:8081 0.0.0.0:* LISTEN 130475/java
```
and the log print:
```
Rest endpoint listening at 127.0.0.:8081
```
and the config item : `jobmanager.web.address` can not fix this problem, unless we add the config :
```
rest.address: 0.0.0.0
```
to override the default `localhost` value
but this config item is not in `flink-conf.yaml`, and user may be not familiar with it.
And I think if we do not change this config's default value, it will confuse users.
---
[GitHub] flink pull request #5632: [FLINK-8843][REST] Decouple bind REST address from...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/5632#discussion_r175073202
--- Diff: flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java ---
@@ -33,7 +33,7 @@
*/
public static final ConfigOption<String> REST_ADDRESS =
key("rest.address")
- .defaultValue("localhost")
+ .defaultValue("0.0.0.0")
--- End diff --
Can I close this PR?
---
[GitHub] flink pull request #5632: [FLINK-8843][REST] Decouple bind REST address from...
Posted by GJL <gi...@git.apache.org>.
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5632#discussion_r175192336
--- Diff: flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java ---
@@ -33,7 +33,7 @@
*/
public static final ConfigOption<String> REST_ADDRESS =
key("rest.address")
- .defaultValue("localhost")
+ .defaultValue("0.0.0.0")
--- End diff --
yes you can close it
---
[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/5632
Thanks for the PR @yanghua, I'll take a look asap.
---
[GitHub] flink pull request #5632: [FLINK-8843][REST] Decouple bind REST address from...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/5632
---
[GitHub] flink issue #5632: [FLINK-8843][REST] Decouple bind REST address from advert...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5632
hi @zentol , it seems @tillrohrmann has no free time recently. Would you please review this?
---