You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/09 22:42:03 UTC
[GitHub] [spark] xinrong-meng opened a new pull request, #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
xinrong-meng opened a new pull request, #39013:
URL: https://github.com/apache/spark/pull/39013
### What changes were proposed in this pull request?
Implement the rest of string/binary functions. The first commit is https://github.com/apache/spark/pull/38921.
### Why are the changes needed?
For API coverage on Spark Connect.
### Does this PR introduce _any_ user-facing change?
Yes. New functions are available on Spark Connect.
### How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39013:
URL: https://github.com/apache/spark/pull/39013#issuecomment-1345729436
LGTM pending python linter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39013:
URL: https://github.com/apache/spark/pull/39013#discussion_r1045334543
##########
python/pyspark/sql/connect/functions.py:
##########
@@ -4159,6 +4159,759 @@ def encode(col: "ColumnOrName", charset: str) -> Column:
return _invoke_function("encode", _to_col(col), lit(charset))
+# TODO(SPARK-41473): Resolve the data type mismatch issue and enable the function
Review Comment:
I will resolve it in a batch, after this PR get merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39013:
URL: https://github.com/apache/spark/pull/39013#discussion_r1045403767
##########
python/pyspark/sql/connect/functions.py:
##########
@@ -4973,7 +5726,7 @@ def unix_timestamp() -> Column:
def unix_timestamp(
- timestamp: Optional["ColumnOrName"] = None, format: str = "yyyy-MM-dd HH:mm:ss"
+ timestamp: Optional["ColumnOrName"] = None, format: str = "yyyy-MM-dd HH:mm:ss"
Review Comment:
```suggestion
timestamp: Optional["ColumnOrName"] = None, format: str = "yyyy-MM-dd HH:mm:ss"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
URL: https://github.com/apache/spark/pull/39013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39013:
URL: https://github.com/apache/spark/pull/39013#issuecomment-1352669725
Let me take over this PR in https://github.com/apache/spark/pull/39071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39013:
URL: https://github.com/apache/spark/pull/39013#issuecomment-1345155835
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-meng commented on pull request #39013: [SPARK-41472][CONNECT][PYTHON] Implement the rest of string/binary functions
Posted by GitBox <gi...@apache.org>.
xinrong-meng commented on PR #39013:
URL: https://github.com/apache/spark/pull/39013#issuecomment-1345590521
@zhengruifeng @amaliujia @HyukjinKwon @grundprinzip Would you please review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org