You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Gary Yao (Jira)" <ji...@apache.org> on 2020/02/28 10:58:00 UTC

[jira] [Commented] (FLINK-15314) To refactor duplicated code in TaskManagerDetailsHandler#createTaskManagerMetricsInfo

    [ https://issues.apache.org/jira/browse/FLINK-15314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047473#comment-17047473 ] 

Gary Yao commented on FLINK-15314:
----------------------------------

The code link doesn't work. Can you update this in the ticket description [~lining]?

> To refactor duplicated code in TaskManagerDetailsHandler#createTaskManagerMetricsInfo
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-15314
>                 URL: https://issues.apache.org/jira/browse/FLINK-15314
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Metrics, Runtime / REST
>            Reporter: lining
>            Priority: Major
>
> As [code|[https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/taskmanager/TaskManagerDetailsHandler.java#L123-L140]] show,  use hard codes to define metrics' name. Could we unify where to register and get metrics? 
>  * propose
>  ** move  metrics'name define in MetricUtils to MetricNames
>  ** the all get the name form MetricNames



--
This message was sent by Atlassian Jira
(v8.3.4#803005)