[GitHub] jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list

[GitBox <gi...@apache.org>]

jiazhai commented on issue #769: defect of merge script: some times not able to get reviewers list
URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-346605849
 
 
   seems related with github api changes?
   this part of code not get the right list,
   ```
       approval_review_states = ['approved']
        pr_reviews = get_json('{0}/pulls/{1}/reviews'.format(GITHUB_API_BASE, pr_num), True)
        for review in pr_reviews:
            for approval_state in approval_review_states:
                if approval_state in review['state'].lower():
                    reviewers_ids.add(review['user']['login'])
   ```
   content of pr_reviews could get from here:  https://api.github.com/repos/apache/bookkeeper/pulls/727/reviews

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services