You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/08/11 09:03:03 UTC

[GitHub] [avro] thiru-mg commented on pull request #1736: AVRO-3547: Add support for custom attributes in Avro Schema

thiru-mg commented on PR #1736:
URL: https://github.com/apache/avro/pull/1736#issuecomment-1211724801

   I'm sorry I didn't look at the PR before. I think the approach taken here exposes the `json` namespace as part of public API. Any future changes hereafter will have to be backwards compatible. When I originally designed the `json` support I took several decisions freely because it was private. Now in one stroke the whole thing opens up for the public.
   Even though support for custom-fields is indeed a welcome enhancement, the side effect of exposing json is much bigger decision. I recommend we revert this change and reintroduce it without exposing json or after a complete review of the JSON.
   Again, I'm sorry I failed to notice it early enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org