[GitHub] [gobblin] aplex commented on a change in pull request #3277: move 'cancel trigger code' from job catalog to job monitor

[GitBox <gi...@apache.org>]

aplex commented on a change in pull request #3277:
URL: https://github.com/apache/gobblin/pull/3277#discussion_r630333358



##########
File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java
##########
@@ -370,9 +372,15 @@ public void handleDeleteJobConfigArrival(DeleteJobConfigArrivalEvent deleteJobAr
   }
 
   @Subscribe
-  public void handleCancelJobConfigArrival(CancelJobConfigArrivalEvent cancelJobArrival)
+  public void handleJobConfigArrival(JobConfigArrivalEvent jobArrival)
       throws InterruptedException {
-    String jobUri = cancelJobArrival.getJoburi();
+    String jobUri = jobArrival.uri.toString();
+
+    if (jobArrival.verb != SpecExecutor.Verb.CANCEL) {
+      LOGGER.info("Received {} event for job uri {}. Taking no action.", jobArrival.verb, jobUri);

Review comment:
       That looks more like trace/debug level.  Will we get a lot of those and spam the logs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org