[GitHub] [airflow] uranusjr commented on a change in pull request #21851: added an option for run id in the ui trigger screen

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #21851:
URL: https://github.com/apache/airflow/pull/21851#discussion_r816022176



##########
File path: airflow/www/views.py
##########
@@ -1838,10 +1839,15 @@ def trigger(self, session=None):
                 form=form,
                 is_dag_run_conf_overrides_params=is_dag_run_conf_overrides_params,
             )
-
-        dr = DagRun.find(dag_id=dag_id, execution_date=execution_date, run_type=DagRunType.MANUAL)
+        # if run_id is not None, filter dag runs based on run id and ignore execution date
+        dr = DagRun.find(
+            dag_id=dag_id,
+            run_type=DagRunType.MANUAL,
+            run_id=run_id,
+            execution_date=execution_date if run_id is None else None,

Review comment:
       We still need to keep the `execution_date` clause when `run_id` is not None for now since two different run IDs with matching `execution_date` will fail.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org