[GitHub] [incubator-nuttx] acassis commented on pull request #4152: arch: Fix rtcb can't found error

[GitBox <gi...@apache.org>]

acassis commented on pull request #4152:
URL: https://github.com/apache/incubator-nuttx/pull/4152#issuecomment-880906492


   > > > Then the proper fix is to add `defined(CONFIG_DEBUG_ALERT)` because _alert is gated by it
   > > 
   > > 
   > > No, it's better to not guard the code, so the compiler can detect the syntax error. Please see this PR to see how many typo error found so far: [5f3a98b](https://github.com/apache/incubator-nuttx/commit/5f3a98b5a8d39a7a9ee1823c6f7eaf05b1822ad7)
   > 
   > I agree we have got to have better testing (test vectors) but shorting the test vectors by increasing code size (in non debug code) is wasting resources and has REAL world limits.
   > 
   > Nuttx has carelessly grown in BOTH RAM and FLASH resources since the last release. Stack penetration is way up. Ton's of code that should be behind Kconfig knob has been added with out limit. The biggest SoC that can do file system functions should not be dictating the FLASH size on a little SoC that does not need chmod, et all.
   > 
   > We use to prioritize SMALL FLASH size a lot now it seems like wanting to be Linux is more a priority
   
   @davids5 during the release of a new version I always test against fw size increasing, but I agree we should have some "bloatware" test in the CI to alarm when the code increase more than 500 bytes or so. Are you tracking it? Just saying that size is increasing it not enough, it will not help much here. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org