You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by liuyu000 <gi...@git.apache.org> on 2018/06/12 06:50:39 UTC
[GitHub] trafodion pull request #1605: [TRAFODION-3104] Add Syntax Descriptions for *...
GitHub user liuyu000 opened a pull request:
https://github.com/apache/trafodion/pull/1605
[TRAFODION-3104] Add Syntax Descriptions for *GET Statement* and Fix Typos in *Trafodion SQL Reference Manual*
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liuyu000/trafodion GetStatement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1605
----
commit f9544e489a5437b02a21bca79fe2da02b669edbe
Author: liu.yu <qw...@...>
Date: 2018-06-12T06:48:45Z
[TRAFODION-3104]Add Syntax Descriptions for *GET Statement* and Fix Typos in *Trafodion SQL Reference Manual*
----
---
[GitHub] trafodion pull request #1605: [TRAFODION-3104] Add Syntax Descriptions for *...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1605#discussion_r195365837
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5268,95 +5268,99 @@ displays a list of all the existing components.
displays the names of all the user-defined functions (UDFs) in the catalog and schema of the current session. By default,
the catalog is TRAFODION, and the schema is SEABASE.
-* `FUNCTIONS FOR LIBRARY \[[_catalog-name_.]_schema-name_.]_library-name_`
+* `FUNCTIONS FOR LIBRARY _[[catalog-name.]schema-name.]library-name_`
+
displays the UDFs that reference the specified library.
-* `functions in schema [_catalog-name_.]_schema-name_`
+* `FUNCTIONS [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the UDFs in the specified schema.
-* `libraries`
+* `LIBRARIES`
+
displays the names of all the libraries in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `libraries in schema [_catalog-name_.]_schema-name_`
+* `LIBRARIES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the libraries in the specified schema.
-* `procedures`
+* `PROCEDURES`
+
displays the names of all the procedures in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `procedures for library \[[_catalog-name_.]_schema-name_.]_library-name_`
+* `PROCEDURES FOR LIBRARY for _[[catalog-name.]schema-name.]library-name_`
+
displays the procedures that reference the specified library.
-* `procedures in schema [_catalog-name_.]_schema-name_`
+* `PROCEDURES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the procedures in the specified schema.
-* `roles`
+* `ROLES`
+
displays a list of all the existing roles.
-* `roles for user _database-username_`
+* `ROLES [FOR USER _database-username_]`
+
displays all the roles that have been granted to the specified database user. The _database-username_ can be a regular or delimited
case-insensitive identifier. see <<case_insensitive_delimited_identifiers,case-insensitive delimited identifiers>>.
-* `schemas`
+* `SCHEMAS`
+
displays the names of all the schemas in the catalog of the current session. By default, the catalog is trafodion.
-* `schemas in catalog _catalog-name_`
+* `SCHEMAS [IN CATALOG _catalog-name_]`
+
displays the names of all the schemas in the specified catalog. For the _catalog-name_, you can specify only trafodion.
-* `schemas for [user | role] _authorization-id_`
+* `SCHEMAS FOR [USER | ROLE] _authorization-id_`
+
displays all the schemas managed (or owned) by a specified user or role.
-* `_authorization-id_`
+** `_authorization-id_`
+
is the name of a user or role. you may specify either user or role for users or roles.
-* `tables`
+* `TABLES`
+
displays the names of all the tables in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `tables in schema [_catalog-name_.]_schema-name_`
+* `TABLES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the tables in the specified schema.
-* `users`
+* `USERS`
+
displays a list of all the registered database users.
-* `users for role _role-name_`
+* `USERS [FOR ROLE _role-name_]`
+
displays all the database users who have been granted the specified role. The _role-name_ can be a regular or delimited
case-insensitive identifier. For more information, see <<case_insensitive_delimited_identifiers,case-insensitive delimited identifiers>>.
<<<
-* `views`
+* `VIEWS`
+
displays the names of all the views in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `views in schema [_catalog-name_.]_schema-name_`
+* `VIEWS [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the views in the specified schema. For the _catalog-name_, you can specify only trafodion.
-* `views on table \[[_catalog-name_.]_schema-name_.]_table-name_`
+* `VIEWS ON TABLE _[[catalog-name.]schema-name.]table-name_`
+
displays the names of all the views that were created for the specified table. If you do not qualify the table name with
catalog and schema names, get uses the catalog and schema of the current session. For the _catalog-name_, you can specify
only trafodion.
+* `PRIVILEGES FOR {USER _database-username_ | ROLE _role-name_}`
++
+displays all privileges for a specified user or role.
+
--- End diff --
Thanks for your remiding @robertamarton I've updated :smiley_cat:
---
[GitHub] trafodion pull request #1605: [TRAFODION-3104] Add Syntax Descriptions for *...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1605
---
[GitHub] trafodion pull request #1605: [TRAFODION-3104] Add Syntax Descriptions for *...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1605#discussion_r195129619
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5268,95 +5268,99 @@ displays a list of all the existing components.
displays the names of all the user-defined functions (UDFs) in the catalog and schema of the current session. By default,
the catalog is TRAFODION, and the schema is SEABASE.
-* `FUNCTIONS FOR LIBRARY \[[_catalog-name_.]_schema-name_.]_library-name_`
+* `FUNCTIONS FOR LIBRARY _[[catalog-name.]schema-name.]library-name_`
+
displays the UDFs that reference the specified library.
-* `functions in schema [_catalog-name_.]_schema-name_`
+* `FUNCTIONS [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the UDFs in the specified schema.
-* `libraries`
+* `LIBRARIES`
+
displays the names of all the libraries in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `libraries in schema [_catalog-name_.]_schema-name_`
+* `LIBRARIES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the libraries in the specified schema.
-* `procedures`
+* `PROCEDURES`
+
displays the names of all the procedures in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `procedures for library \[[_catalog-name_.]_schema-name_.]_library-name_`
+* `PROCEDURES FOR LIBRARY for _[[catalog-name.]schema-name.]library-name_`
+
displays the procedures that reference the specified library.
-* `procedures in schema [_catalog-name_.]_schema-name_`
+* `PROCEDURES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the procedures in the specified schema.
-* `roles`
+* `ROLES`
+
displays a list of all the existing roles.
-* `roles for user _database-username_`
+* `ROLES [FOR USER _database-username_]`
+
displays all the roles that have been granted to the specified database user. The _database-username_ can be a regular or delimited
case-insensitive identifier. see <<case_insensitive_delimited_identifiers,case-insensitive delimited identifiers>>.
-* `schemas`
+* `SCHEMAS`
+
displays the names of all the schemas in the catalog of the current session. By default, the catalog is trafodion.
-* `schemas in catalog _catalog-name_`
+* `SCHEMAS [IN CATALOG _catalog-name_]`
+
displays the names of all the schemas in the specified catalog. For the _catalog-name_, you can specify only trafodion.
-* `schemas for [user | role] _authorization-id_`
+* `SCHEMAS FOR [USER | ROLE] _authorization-id_`
+
displays all the schemas managed (or owned) by a specified user or role.
-* `_authorization-id_`
+** `_authorization-id_`
+
is the name of a user or role. you may specify either user or role for users or roles.
-* `tables`
+* `TABLES`
+
displays the names of all the tables in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `tables in schema [_catalog-name_.]_schema-name_`
+* `TABLES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the tables in the specified schema.
-* `users`
+* `USERS`
+
displays a list of all the registered database users.
-* `users for role _role-name_`
+* `USERS [FOR ROLE _role-name_]`
+
displays all the database users who have been granted the specified role. The _role-name_ can be a regular or delimited
case-insensitive identifier. For more information, see <<case_insensitive_delimited_identifiers,case-insensitive delimited identifiers>>.
<<<
-* `views`
+* `VIEWS`
+
displays the names of all the views in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `views in schema [_catalog-name_.]_schema-name_`
+* `VIEWS [IN SCHEMA _[catalog-name.]schema-name_`
+
--- End diff --
Need an ending "]"
---
[GitHub] trafodion pull request #1605: [TRAFODION-3104] Add Syntax Descriptions for *...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1605#discussion_r195132039
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5268,95 +5268,99 @@ displays a list of all the existing components.
displays the names of all the user-defined functions (UDFs) in the catalog and schema of the current session. By default,
the catalog is TRAFODION, and the schema is SEABASE.
-* `FUNCTIONS FOR LIBRARY \[[_catalog-name_.]_schema-name_.]_library-name_`
+* `FUNCTIONS FOR LIBRARY _[[catalog-name.]schema-name.]library-name_`
+
displays the UDFs that reference the specified library.
-* `functions in schema [_catalog-name_.]_schema-name_`
+* `FUNCTIONS [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the UDFs in the specified schema.
-* `libraries`
+* `LIBRARIES`
+
displays the names of all the libraries in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `libraries in schema [_catalog-name_.]_schema-name_`
+* `LIBRARIES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the libraries in the specified schema.
-* `procedures`
+* `PROCEDURES`
+
displays the names of all the procedures in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `procedures for library \[[_catalog-name_.]_schema-name_.]_library-name_`
+* `PROCEDURES FOR LIBRARY for _[[catalog-name.]schema-name.]library-name_`
+
displays the procedures that reference the specified library.
-* `procedures in schema [_catalog-name_.]_schema-name_`
+* `PROCEDURES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the procedures in the specified schema.
-* `roles`
+* `ROLES`
+
displays a list of all the existing roles.
-* `roles for user _database-username_`
+* `ROLES [FOR USER _database-username_]`
+
displays all the roles that have been granted to the specified database user. The _database-username_ can be a regular or delimited
case-insensitive identifier. see <<case_insensitive_delimited_identifiers,case-insensitive delimited identifiers>>.
-* `schemas`
+* `SCHEMAS`
+
displays the names of all the schemas in the catalog of the current session. By default, the catalog is trafodion.
-* `schemas in catalog _catalog-name_`
+* `SCHEMAS [IN CATALOG _catalog-name_]`
+
displays the names of all the schemas in the specified catalog. For the _catalog-name_, you can specify only trafodion.
-* `schemas for [user | role] _authorization-id_`
+* `SCHEMAS FOR [USER | ROLE] _authorization-id_`
+
displays all the schemas managed (or owned) by a specified user or role.
-* `_authorization-id_`
+** `_authorization-id_`
+
is the name of a user or role. you may specify either user or role for users or roles.
-* `tables`
+* `TABLES`
+
displays the names of all the tables in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `tables in schema [_catalog-name_.]_schema-name_`
+* `TABLES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the tables in the specified schema.
-* `users`
+* `USERS`
+
displays a list of all the registered database users.
-* `users for role _role-name_`
+* `USERS [FOR ROLE _role-name_]`
+
displays all the database users who have been granted the specified role. The _role-name_ can be a regular or delimited
case-insensitive identifier. For more information, see <<case_insensitive_delimited_identifiers,case-insensitive delimited identifiers>>.
<<<
-* `views`
+* `VIEWS`
+
displays the names of all the views in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `views in schema [_catalog-name_.]_schema-name_`
+* `VIEWS [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the views in the specified schema. For the _catalog-name_, you can specify only trafodion.
-* `views on table \[[_catalog-name_.]_schema-name_.]_table-name_`
+* `VIEWS ON TABLE _[[catalog-name.]schema-name.]table-name_`
+
displays the names of all the views that were created for the specified table. If you do not qualify the table name with
catalog and schema names, get uses the catalog and schema of the current session. For the _catalog-name_, you can specify
only trafodion.
+* `PRIVILEGES FOR {USER _database-username_ | ROLE _role-name_}`
++
+displays all privileges for a specified user or role.
+
--- End diff --
Consistency, the other commands you did {USER | ROLE} authorization_id, may want to do the same here.
---
[GitHub] trafodion pull request #1605: [TRAFODION-3104] Add Syntax Descriptions for *...
Posted by liuyu000 <gi...@git.apache.org>.
Github user liuyu000 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1605#discussion_r195359872
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5268,95 +5268,99 @@ displays a list of all the existing components.
displays the names of all the user-defined functions (UDFs) in the catalog and schema of the current session. By default,
the catalog is TRAFODION, and the schema is SEABASE.
-* `FUNCTIONS FOR LIBRARY \[[_catalog-name_.]_schema-name_.]_library-name_`
+* `FUNCTIONS FOR LIBRARY _[[catalog-name.]schema-name.]library-name_`
+
displays the UDFs that reference the specified library.
-* `functions in schema [_catalog-name_.]_schema-name_`
+* `FUNCTIONS [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the UDFs in the specified schema.
-* `libraries`
+* `LIBRARIES`
+
displays the names of all the libraries in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `libraries in schema [_catalog-name_.]_schema-name_`
+* `LIBRARIES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the libraries in the specified schema.
-* `procedures`
+* `PROCEDURES`
+
displays the names of all the procedures in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `procedures for library \[[_catalog-name_.]_schema-name_.]_library-name_`
+* `PROCEDURES FOR LIBRARY for _[[catalog-name.]schema-name.]library-name_`
+
displays the procedures that reference the specified library.
-* `procedures in schema [_catalog-name_.]_schema-name_`
+* `PROCEDURES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the procedures in the specified schema.
-* `roles`
+* `ROLES`
+
displays a list of all the existing roles.
-* `roles for user _database-username_`
+* `ROLES [FOR USER _database-username_]`
+
displays all the roles that have been granted to the specified database user. The _database-username_ can be a regular or delimited
case-insensitive identifier. see <<case_insensitive_delimited_identifiers,case-insensitive delimited identifiers>>.
-* `schemas`
+* `SCHEMAS`
+
displays the names of all the schemas in the catalog of the current session. By default, the catalog is trafodion.
-* `schemas in catalog _catalog-name_`
+* `SCHEMAS [IN CATALOG _catalog-name_]`
+
displays the names of all the schemas in the specified catalog. For the _catalog-name_, you can specify only trafodion.
-* `schemas for [user | role] _authorization-id_`
+* `SCHEMAS FOR [USER | ROLE] _authorization-id_`
+
displays all the schemas managed (or owned) by a specified user or role.
-* `_authorization-id_`
+** `_authorization-id_`
+
is the name of a user or role. you may specify either user or role for users or roles.
-* `tables`
+* `TABLES`
+
displays the names of all the tables in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `tables in schema [_catalog-name_.]_schema-name_`
+* `TABLES [IN SCHEMA _[catalog-name.]schema-name_`
+
displays the names of all the tables in the specified schema.
-* `users`
+* `USERS`
+
displays a list of all the registered database users.
-* `users for role _role-name_`
+* `USERS [FOR ROLE _role-name_]`
+
displays all the database users who have been granted the specified role. The _role-name_ can be a regular or delimited
case-insensitive identifier. For more information, see <<case_insensitive_delimited_identifiers,case-insensitive delimited identifiers>>.
<<<
-* `views`
+* `VIEWS`
+
displays the names of all the views in the catalog and schema of the current session. By default, the catalog is trafodion,
and the schema is seabase.
-* `views in schema [_catalog-name_.]_schema-name_`
+* `VIEWS [IN SCHEMA _[catalog-name.]schema-name_`
+
--- End diff --
Oops, thanks for your eagle eye @robertamarton :+1: I've corrected :raising_hand_woman:
---