You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "xinglin (via GitHub)" <gi...@apache.org> on 2023/08/09 06:34:59 UTC

[GitHub] [hadoop] xinglin commented on pull request #5926: HADOOP-18840. Add enQueue time to RpcMetrics

xinglin commented on PR #5926:
URL: https://github.com/apache/hadoop/pull/5926#issuecomment-1670753258

   > > @2005hithlj Please check the failed unit test and checkstyle.
   > 
   > @Hexiaoqiao sir. The failed UT 'TestRPCCallBenchmark is not related to my modification, and it will success in my modification branch in my local env.
   > 
   > And Checkstyle Warn: RpcMetrics.java:122: @Metric("EQueue time") MutableRate rpcEnQueueTime;:38: Variable 'rpcEnQueueTime' must be private and have accessor methods. [VisibilityModifier] RpcMetrics.java:123: MutableQuantiles[] rpcEnQueueTimeQuantiles;:22: Variable 'rpcEnQueueTimeQuantiles' must be private and have accessor methods. [VisibilityModifier]
   > 
   > If I follow the above prompts to modify, it will break the style of the RpcMetrics class.
   
   I don't know the unit test but yeah, for the checkstyle, we can ignore these warnings: for metrics, we don't add visibility modifier. None of the existing metrics has the visibility modifier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org