[GitHub] [incubator-druid] himanshug commented on a change in pull request #8244: Update docker build

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #8244: Update docker build
URL: https://github.com/apache/incubator-druid/pull/8244#discussion_r311182645
 
 

 ##########
 File path: distribution/docker/druid.sh
 ##########
 @@ -45,45 +45,56 @@ echo "$(date -Is) startup service $SERVICE"
 
 # We put all the config in /tmp/conf to allow for a
 # read-only root filesystem
-cp -r /opt/druid/conf /tmp/conf
+mkdir -p /tmp/conf/
+cp -r /opt/druid/conf/druid /tmp/conf/druid
+
+getConfPath() {
+    cluster_conf_base=/tmp/conf/druid/cluster
+    case "$1" in
+    _common) echo $cluster_conf_base/_common ;;
+    historical) echo $cluster_conf_base/data/historical ;;
+    middleManager) echo $cluster_conf_base/data/middleManager ;;
+    coordinator | overlord) echo $cluster_conf_base/master/coordinator-overlord ;;
 
 Review comment:
   it is still possible I think, one container would be running one of the following druid process...
   - standalone coordinator process (in that case runtime.properties could contain configs relevant to coordinator)
   - standalone overlord process (in that case runtime.properties could contain confits relevant to overlord)
   - combined coordinator+overlord process (in that case runtime.properties could contain all config)
   
   Also, it looks like possible to use "DRUID_CONFIG_COMMON" and "DRUID_CONFIG_{service}" variables to use a different directory layout. (inferring from line #114 on changed file)
   
   Disclaimer: I haven't really done any of above, these are observations made by quickly reading the script :)
   
   
   
   I think current state is trying to make it super easy for druid example cluster config to work with minimal/no changes which is a worth goal for people trying things out and setting up a small cluster.
   
   That said, It might still be a good idea to support separate overlord/coordinator process config in a more obvious way or at least document how to achieve that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org